From: Stephan Gerhold <stephan@gerhold.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Ondřej Jirman" <megous@megous.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
"Simon Budig" <simon.budig@kernelconcepts.de>,
"Marco Felsch" <m.felsch@pengutronix.de>
Subject: Re: [PATCH v2 2/2] Input: edt-ft5x06 - add support for iovcc-supply
Date: Tue, 11 May 2021 10:50:01 +0200 [thread overview]
Message-ID: <YJpFOVv1ifKBEwWV@gerhold.net> (raw)
In-Reply-To: <YJowd/tDgVD2TBKO@smile.fi.intel.com>
On Tue, May 11, 2021 at 10:21:27AM +0300, Andy Shevchenko wrote:
> On Mon, May 10, 2021 at 10:16:41PM +0200, Stephan Gerhold wrote:
> > On Mon, May 10, 2021 at 09:48:48PM +0200, Ondřej Jirman wrote:
> >
> > - Bulk regulator API: AFAICT there is no way to use it while also
> > maintaining the correct enable/disable order plus the 10us delay.
> > See https://lore.kernel.org/linux-input/X%2Fwj+bxe%2FIlznCj6@gerhold.net/
>
> This by the way can be fixed on regulator level (adding some like ranges into
> bulk structure with timeouts, and if 0, skip them).
>
At the moment the bulk regulator API seems specifically designed to
enable all the regulators at the same time (with some funky asynchronous
scheduling code). I'm not sure if there is a straightforward way to
fit in a sequential enable/disable order with potential delays.
I'm also not entirely convinced it's worth it in this case. I would say
the code in this patch (except for the dev_err_probe()) is still quite
easy to read. Encoding the enable/disable order + delays in some bulk
regulator struct might actually be more difficult to read.
Thanks,
Stephan
prev parent reply other threads:[~2021-05-11 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 19:31 [PATCH v2 1/2] dt-bindings: input: touchscreen: edt-ft5x06: add iovcc-supply Stephan Gerhold
2021-05-10 19:31 ` [PATCH v2 2/2] Input: edt-ft5x06 - add support for iovcc-supply Stephan Gerhold
2021-05-10 19:48 ` Ondřej Jirman
2021-05-10 20:09 ` Andy Shevchenko
2021-05-10 20:17 ` Ondřej Jirman
2021-05-10 20:16 ` Stephan Gerhold
2021-05-10 21:14 ` Ondřej Jirman
2021-05-11 7:21 ` Andy Shevchenko
2021-05-11 7:42 ` Marco Felsch
2021-05-11 8:50 ` Stephan Gerhold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJpFOVv1ifKBEwWV@gerhold.net \
--to=stephan@gerhold.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=megous@megous.com \
--cc=robh+dt@kernel.org \
--cc=simon.budig@kernelconcepts.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).