From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Salah Triki <salah.triki@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: powermate: update the reference count of the usb interface structure
Date: Sat, 24 Jul 2021 16:08:02 -0700 [thread overview]
Message-ID: <YPydUp9vc5U7vGIw@google.com> (raw)
In-Reply-To: <20210724212016.GA568154@pc>
Hi,
On Sat, Jul 24, 2021 at 10:20:16PM +0100, Salah Triki wrote:
> Use usb_get_intf() and usb_put_intf() in order to update the reference
> count of the usb interface structure.
This is quite pointless as the driver will be unbound from the interface
before interface is deleted.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
> drivers/input/misc/powermate.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/powermate.c b/drivers/input/misc/powermate.c
> index c4e0e1886061..69dc3347478a 100644
> --- a/drivers/input/misc/powermate.c
> +++ b/drivers/input/misc/powermate.c
> @@ -337,7 +337,7 @@ static int powermate_probe(struct usb_interface *intf, const struct usb_device_i
> goto fail3;
>
> pm->udev = udev;
> - pm->intf = intf;
> + pm->intf = usb_get_intf(intf);
> pm->input = input_dev;
>
> usb_make_path(udev, pm->phys, sizeof(pm->phys));
> @@ -428,6 +428,7 @@ static void powermate_disconnect(struct usb_interface *intf)
> usb_free_urb(pm->irq);
> usb_free_urb(pm->config);
> powermate_free_buffers(interface_to_usbdev(intf), pm);
> + usb_put_intf(pm->intf);
>
> kfree(pm);
> }
> --
> 2.25.1
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-07-24 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-24 21:20 [PATCH] misc: powermate: update the reference count of the usb interface structure Salah Triki
2021-07-24 23:08 ` Dmitry Torokhov [this message]
2021-07-24 23:56 ` Salah Triki
2021-07-25 4:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPydUp9vc5U7vGIw@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).