From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: mateng <ayowoe@163.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
mateng <mateng@yulong.com>
Subject: Re: [PATCH] input/serio:unneeded variable:delay
Date: Fri, 3 Sep 2021 23:54:43 -0700 [thread overview]
Message-ID: <YTMYM6s+PZA/r1mw@google.com> (raw)
In-Reply-To: <20210323070250.1306-1-ayowoe@163.com>
On Tue, Mar 23, 2021 at 03:02:50PM +0800, mateng wrote:
> From: mateng <mateng@yulong.com>
>
> delete unneeded variable 'delay'
Sorry, but this is bogus.
>
> Signed-off-by: mateng <mateng@yulong.com>
> ---
> drivers/input/serio/i8042.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
> index abae23a..145bda1 100644
> --- a/drivers/input/serio/i8042.c
> +++ b/drivers/input/serio/i8042.c
> @@ -1126,7 +1126,6 @@ static void i8042_controller_reset(bool s2r_wants_reset)
>
> static long i8042_panic_blink(int state)
> {
> - long delay = 0;
> char led;
>
> led = (state) ? 0x01 | 0x04 : 0;
> @@ -1142,7 +1141,7 @@ static long i8042_panic_blink(int state)
> dbg("%02x -> i8042 (panic blink)\n", led);
> i8042_write_data(led);
> DELAY;
> - return delay;
> + return 0;
> }
>
> #undef DELAY
> --
> 1.9.1
>
--
Dmitry
prev parent reply other threads:[~2021-09-04 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 7:02 [PATCH] input/serio:unneeded variable:delay mateng
2021-09-04 6:54 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTMYM6s+PZA/r1mw@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=ayowoe@163.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateng@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).