Re: [PATCH] input: rmi_spi: Add missing entries SPI to device ID table

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Mark,

On Mon, Sep 27, 2021 at 02:40:00PM +0100, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table, it uses
> SPI modalises. Supporting OF modalises is going to be difficult if not
> impractical, an attempt was made but has been reverted, so ensure that
> module autoloading works for this driver by adding SPI IDs for parts that
> only have a compatible listed.
> 
> Fixes: 96c8395e2166 ("spi: Revert modalias changes")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/input/rmi4/rmi_spi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4/rmi_spi.c
> index c82edda66b23..1dccb8dd8919 100644
> --- a/drivers/input/rmi4/rmi_spi.c
> +++ b/drivers/input/rmi4/rmi_spi.c
> @@ -511,6 +511,7 @@ static const struct dev_pm_ops rmi_spi_pm = {
>  
>  static const struct spi_device_id rmi_id[] = {
>  	{ "rmi4_spi", 0 },
> +	{ "rmi4-spi", 0 },

I do not think this is needed as kmod "normalizes" module names and
modalias strings by converting all dashes to underscore before executing
matching.

Thanks.

-- 
Dmitry