linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, ~okias/devicetree@lists.sr.ht
Subject: Re: [PATCH] dt-bindings: input: mcs-touchkey: Convert txt bindings to yaml
Date: Tue, 19 Oct 2021 16:48:05 -0500	[thread overview]
Message-ID: <YW89FX52NQNBzQ/2@robh.at.kernel.org> (raw)
In-Reply-To: <20211009104837.46626-1-david@ixit.cz>

On Sat, Oct 09, 2021 at 12:48:37PM +0200, David Heidelberg wrote:
> Convert MELFAS MCS-5000 touchscreen controller chip documentation to the YAML format.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  .../bindings/input/mcs-touchkey.txt           | 26 ---------
>  .../bindings/input/mcs-touchkey.yaml          | 53 +++++++++++++++++++
>  2 files changed, 53 insertions(+), 26 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/mcs-touchkey.txt

I don't have this file in my tree.

>  create mode 100644 Documentation/devicetree/bindings/input/mcs-touchkey.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/mcs-touchkey.txt b/Documentation/devicetree/bindings/input/mcs-touchkey.txt
> deleted file mode 100644
> index 545454112a43..000000000000
> --- a/Documentation/devicetree/bindings/input/mcs-touchkey.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -* mcs_touchkey MELFAS MCS5000/5080 controller
> -
> -Required properties:
> -- compatible: must be "mcs5000_touchkey" or "mcs5080_touchkey"
> -- reg : I2C address of the chip
> -- interrupts: interrupt to which the chop is connected
> -- key_maxval: size of keycode table
> -- interrupts: interrupt to which the chip is connected
> -- code: key code for this device
> -
> -Example:
> -
> -	i2c_touch_key: i2c-gpio-0 {
> -	       /* ... */
> -
> -	       touch_key@20 {
> -		       compatible = "mcs5080_touchkey";
> -		       reg = <0x20>;
> -		       interrupt-patrent = <gpj0>;
> -		       key_maxval = <2>;
> -		       linux, code = <0x0000009e
> -			              0x000000a9>;
> -	       };
> -
> -	       /* ... */
> -	};
> diff --git a/Documentation/devicetree/bindings/input/mcs-touchkey.yaml b/Documentation/devicetree/bindings/input/mcs-touchkey.yaml
> new file mode 100644
> index 000000000000..b56de0361ff8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/mcs-touchkey.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/mcs-touchkey.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MELFAS MCS5000/5080 controller
> +
> +maintainers:
> +  - Rob Herring <robh+dt@kernel.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - mcs5000_touchkey
> +      - mcs5080_touchkey
> +
> +  reg: true
> +  interrupts: true
> +  key_maxval:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: size of keycode table
> +
> +  linux,code:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description: key code for this device
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - linux,code
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/tegra-gpio.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c_touch_key: i2c-gpio-0 {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      melfas-touchkey@20 {
> +        compatible = "mcs5080_touchkey";
> +        reg = <0x20>;
> +        interrupt-parent = <&gpio>;
> +        interrupts = <TEGRA_GPIO(Q, 4) IRQ_TYPE_EDGE_FALLING>;
> +        key_maxval = <4>;
> +        linux,code = <139 102 158 217>;
> +      };
> +    };
> -- 
> 2.33.0
> 
> 

  reply	other threads:[~2021-10-19 21:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 10:48 [PATCH] dt-bindings: input: mcs-touchkey: Convert txt bindings to yaml David Heidelberg
2021-10-19 21:48 ` Rob Herring [this message]
2021-10-19 21:55   ` David Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YW89FX52NQNBzQ/2@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=~okias/devicetree@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).