From: Greg KH <gregkh@linuxfoundation.org>
To: lianzhi chang <changlianzhi@uniontech.com>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
jirislaby@kernel.org, andriy.shevchenko@linux.intel.com,
linux-input@vger.kernel.org, 282827961@qq.com
Subject: Re: [PATCH] input&tty: Fix the keyboard led light display problem
Date: Fri, 15 Oct 2021 10:41:13 +0200 [thread overview]
Message-ID: <YWk+qaUnN+M/dX9o@kroah.com> (raw)
In-Reply-To: <20211015083613.7429-1-changlianzhi@uniontech.com>
On Fri, Oct 15, 2021 at 04:36:13PM +0800, lianzhi chang wrote:
> Switching from the desktop environment to the tty environment,
> the state of the keyboard led lights and the state of the keyboard
> lock are inconsistent. This is because the attribute kb->kbdmode
> of the tty bound in the desktop environment (xorg) is set to
> VC_OFF, which causes the ledstate and kb->ledflagstate
> values of the bound tty to always be 0, which causes the switch
> from the desktop When to the tty environment, the LED light
> status is inconsistent with the keyboard lock status.
>
> Signed-off-by: lianzhi chang <changlianzhi@uniontech.com>
> ---
> The latest changes:
> (1) Move the definition of ledstate to the input module (/drivers/input/input.c),
> and set or get its value through the input_update_ledstate and input_get_ledstate
> functions.
> (2) To update the ledstate reference in keyboard.c, you must first get the value
> through input_get_ledstate.
> (3) Other necessary changes
You have not changed the subject line at all.
Look at how others submit patches that are new versions on the mailing
list, and most importantly, read the documentation we have about this.
thanks,
greg k-h
next parent reply other threads:[~2021-10-15 8:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211015083613.7429-1-changlianzhi@uniontech.com>
2021-10-15 8:41 ` Greg KH [this message]
[not found] ` <616942b2.1c69fb81.dfbff.25afSMTPIN_ADDED_BROKEN@mx.google.com>
2021-10-15 10:16 ` [PATCH] input&tty: Fix the keyboard led light display problem Greg KH
[not found] <35696980-2a55-c5c1-3fa9-eadf251dcdde@uniontech.com>
2021-10-15 13:06 ` Andy Shevchenko
2021-10-15 8:37 lianzhi chang
[not found] <61693925.1c69fb81.a058.27f2SMTPIN_ADDED_BROKEN@mx.google.com>
2021-10-15 8:25 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2021-10-15 6:45 lianzhi chang
2021-10-15 6:52 ` Greg KH
[not found] ` <616934f3.1c69fb81.59ff6.49d9SMTPIN_ADDED_BROKEN@mx.google.com>
2021-10-15 8:04 ` Greg KH
2021-10-15 1:20 lianzhi chang
2021-10-14 8:53 lianzhi chang
[not found] ` <616827d8.1c69fb81.75aa0.eea0SMTPIN_ADDED_BROKEN@mx.google.com>
2021-10-14 13:21 ` gregkh
[not found] <20211014071627.23256-1-changlianzhi@uniontech.com>
2021-10-14 7:34 ` Greg KH
2021-10-14 15:13 ` Andy Shevchenko
2021-10-14 14:55 ` Jiri Slaby
2021-10-14 18:20 ` Dmitry Torokhov
2021-10-14 7:20 lianzhi chang
[not found] <20211014040508.8367-1-changlianzhi@uniontech.com>
2021-10-14 4:12 ` Jiri Slaby
[not found] <20211014030836.30612-1-changlianzhi@uniontech.com>
2021-10-14 4:12 ` Jiri Slaby
2021-10-14 4:06 lianzhi chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWk+qaUnN+M/dX9o@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=282827961@qq.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=changlianzhi@uniontech.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).