From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "André Draszik" <git@andred.net>,
"Shawn Guo" <shawnguo@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
kernel@pengutronix.de, linux-input@vger.kernel.org
Subject: Re: [PATCH v2] Input: snvs_pwrkey - Add clk handling
Date: Fri, 15 Oct 2021 22:28:59 -0700 [thread overview]
Message-ID: <YWpjG3s1CeO19xiG@google.com> (raw)
In-Reply-To: <20211013062848.2667192-1-u.kleine-koenig@pengutronix.de>
On Wed, Oct 13, 2021 at 08:28:48AM +0200, Uwe Kleine-König wrote:
> On i.MX7S and i.MX8M* (but not i.MX6*) the pwrkey device has an
> associated clock. Accessing the registers requires that this clock is
> enabled. Binding the driver on at least i.MX7S and i.MX8MP while not
> having the clock enabled results in a complete hang of the machine.
> (This usually only happens if snvs_pwrkey is built as a module and the
> rtc-snvs driver isn't already bound because at bootup the required clk
> is on and only gets disabled when the clk framework disables unused clks
> late during boot.)
>
> This completes the fix in commit 135be16d3505 ("ARM: dts: imx7s: add
> snvs clock to pwrkey").
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2021-10-16 5:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 9:43 [PATCH] Input: snvs_pwrkey - Add clk handling Uwe Kleine-König
2021-10-05 20:00 ` Uwe Kleine-König
2021-10-12 1:48 ` Dmitry Torokhov
2021-10-12 7:39 ` Uwe Kleine-König
2021-10-13 3:06 ` Dmitry Torokhov
2021-10-13 6:28 ` [PATCH v2] " Uwe Kleine-König
2021-10-16 5:28 ` Dmitry Torokhov [this message]
2021-10-13 7:26 ` [PATCH] " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWpjG3s1CeO19xiG@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=git@andred.net \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).