From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc@vger.kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Marc Zyngier <maz@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: input: gpio-keys: Fix interrupts in example
Date: Mon, 6 Dec 2021 14:17:00 -0600 [thread overview]
Message-ID: <Ya5vvOtq2kgf9hkT@robh.at.kernel.org> (raw)
In-Reply-To: <47ecd2d8efcf09f8ab47de87a7bcfafc82208776.1638538079.git.geert+renesas@glider.be>
On Fri, 03 Dec 2021 14:35:06 +0100, Geert Uytterhoeven wrote:
> The "interrupts" property in the example looks weird:
> - The type is not in the last cell,
> - Level interrupts don't work well with gpio-keys, as they keep the
> interrupt asserted as long as the key is pressed, causing an
> interrupt storm.
>
> Use a more realistic falling-edge interrupt instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
next prev parent reply other threads:[~2021-12-06 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 13:35 [PATCH 0/3] Input: gpio-keys - Interrupt-related fixes Geert Uytterhoeven
2021-12-03 13:35 ` [PATCH 1/3] dt-bindings: input: gpio-keys: Fix interrupts in example Geert Uytterhoeven
2021-12-06 20:17 ` Rob Herring [this message]
2021-12-03 13:35 ` [PATCH 2/3] Input: gpio-keys - Use input_report_key() Geert Uytterhoeven
2021-12-03 13:35 ` [PATCH RFC 3/3] Input: gpio-keys - Fix ghost events with both-edge irqs Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya5vvOtq2kgf9hkT@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).