Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Mon, Dec 06, 2021 at 08:46:50PM +1000, Alistair Francis wrote:
> On Sun, Dec 5, 2021 at 8:32 AM Andreas Kemnade <andreas@kemnade.info> wrote:
> >
> > Hi,
> >
> >
> > On Thu,  2 Dec 2021 22:20:18 +1000
> > Alistair Francis <alistair@alistair23.me> wrote:
> >
> > > From: Mylène Josserand <mylene.josserand@bootlin.com>
> > >
> > > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> > > controllers. This driver supports only the I2C bus but it uses regmap
> > > so SPI support could be added later.
> > > The touchscreen can retrieve some defined zone that are handled as
> > > buttons (according to the hardware). That is why it handles
> > > button and multitouch events.
> > >
> > > Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > > Signed-off-by: Mylène Josserand <mylene.josserand@bootlin.com>
> > > Message-Id: <20180703094309.18514-2-mylene.josserand@bootlin.com>
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> >
> > I finally got it working. The order of initialisation is important.
> > Params are copied on input_mt_init_slots() from ABS_MT* to ABS_*, so you
> > have to set params first.
> >
> > Here is the patch i need on top of this one to make it actually work
> > with X (evdev and libinput is tested):
> >
> > diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> > index b5d96eb71e46..3894ec85a732 100644
> > --- a/drivers/input/touchscreen/cyttsp5.c
> > +++ b/drivers/input/touchscreen/cyttsp5.c
> > @@ -415,19 +415,12 @@ static int cyttsp5_setup_input_device(struct device *dev)
> >         int max_x_tmp, max_y_tmp;
> >         int error;
> >
> > -       __set_bit(EV_REL, ts->input->evbit);
> 
> Does it work with this still included? I need this for my userspace program.

You need to fix your program, the kernel should not be declaring
capabilities that the device does not support.

Thanks.

-- 
Dmitry