From: Lee Jones <lee.jones@linaro.org>
To: Dario Binacchi <dariobin@libero.it>
Cc: linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-input@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Zubair Lutfullah <zubair.lutfullah@gmail.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dave Gerlach <d-gerlach@ti.com>, "Andrew F . Davis" <afd@ti.com>,
Vignesh R <vigneshr@ti.com>, Wolfram Sang <wsa@kernel.org>,
Brad Griffis <bgriffis@ti.com>, Jeff Lance <j-lance1@ti.com>,
Rachna Patil <rachna@ti.com>
Subject: Re: [PATCH v2 4/4] mfd: ti_am335x_tscadc: drop the CNTRLREG_TSC_8WIRE macro
Date: Fri, 26 Nov 2021 08:58:41 +0000 [thread overview]
Message-ID: <YaChwbp3lno/07fV@google.com> (raw)
In-Reply-To: <20211125224642.21011-5-dariobin@libero.it>
On Thu, 25 Nov 2021, Dario Binacchi wrote:
> In TI's reference manual description for the `AFE_Pen_Ctrl' bit-field
> of the TSC's CTRL register, there is no mention of 8-wire touchscreens.
> Even commit f0933a60d190 ("mfd: ti_am335x_tscadc: Update logic in CTRL
> register for 5-wire TS") says that the value of this bit-field must be
> the same for 4-wire and 8-wire touchscreens. So let's remove the
> CNTRLREG_TSC_8WIRE macro to avoid misunderstandings.
>
> Signed-off-by: Dario Binacchi <dariobin@libero.it>
>
> ---
>
> Changes in v2:
> - Replace CNTRLREG_8WIRE with CNTRLREG_TSC_8WIRE. In the meantime, the
> file ti_am335x_tscadc.h has been modified, so the patch must be
> updated.
>
> include/linux/mfd/ti_am335x_tscadc.h | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-11-26 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 22:46 [PATCH v2 0/4] input: touchscreen: am335x: fix and improvements Dario Binacchi
2021-11-25 22:46 ` [PATCH v2 1/4] input: ti_am335x_tsc: set ADCREFM for X configuration Dario Binacchi
2021-11-25 22:46 ` [PATCH v2 2/4] input: ti_am335x_tsc: fix STEPCONFIG setup for Z2 Dario Binacchi
2021-11-25 22:46 ` [PATCH v2 3/4] input: ti_am335x_tsc: lower the X and Y sampling time Dario Binacchi
2021-11-25 22:46 ` [PATCH v2 4/4] mfd: ti_am335x_tscadc: drop the CNTRLREG_TSC_8WIRE macro Dario Binacchi
2021-11-26 8:58 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaChwbp3lno/07fV@google.com \
--to=lee.jones@linaro.org \
--cc=afd@ti.com \
--cc=balbi@ti.com \
--cc=bgriffis@ti.com \
--cc=bigeasy@linutronix.de \
--cc=d-gerlach@ti.com \
--cc=dariobin@libero.it \
--cc=dmitry.torokhov@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=j-lance1@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rachna@ti.com \
--cc=vigneshr@ti.com \
--cc=wsa@kernel.org \
--cc=zubair.lutfullah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).