From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F091C433EF for ; Mon, 14 Feb 2022 22:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231956AbiBNWmw (ORCPT ); Mon, 14 Feb 2022 17:42:52 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231579AbiBNWmw (ORCPT ); Mon, 14 Feb 2022 17:42:52 -0500 Received: from hs01.dk-develop.de (hs01.dk-develop.de [173.249.23.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5588115C64C for ; Mon, 14 Feb 2022 14:42:43 -0800 (PST) Date: Mon, 14 Feb 2022 23:42:38 +0100 From: Danilo Krummrich To: Krzysztof Kozlowski Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org Subject: Re: [PATCH 2/2] input: ps2-gpio: enforce and document open drain Message-ID: References: <20220211233137.99624-1-danilokrummrich@dk-develop.de> <20220211233137.99624-3-danilokrummrich@dk-develop.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Feb 14, 2022 at 10:50:21PM +0100, Krzysztof Kozlowski wrote: > On 12/02/2022 00:31, Danilo Krummrich wrote: > > The PS/2 bus defines the data and clock line be open drain, therefore > > document this in the dt-binding and enforce the particular flag in the > > driver. > > > > Without enforcing to flag at least the clock gpio as open drain we run > > into the following warning: > > > > WARNING: CPU: 1 PID: 40 at drivers/gpio/gpiolib.c:3175 gpiochip_enable_irq+0x54/0x90 > > > > gpiochip_enable_irq() warns on a GPIO being configured as output and > > using IRQ without being flagged as open drain. > > > > Signed-off-by: Danilo Krummrich > > --- > > .../devicetree/bindings/serio/ps2-gpio.yaml | 14 ++++++++++---- > > drivers/input/serio/ps2-gpio.c | 9 +++++++-- > > 2 files changed, 17 insertions(+), 6 deletions(-) > > > > Bindings as separate patch, please. Are you fine with adding this additional documentation directly to the patch converting the binding to a json-schema or do you prefer it to be a separate patch? > > Best regards, > Krzysztof - Danilo