From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com,
Jiri Kosina <jikos@kernel.org>,
linux-input@vger.kernel.org, Sean O'Brien <seobrien@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
Subject: Re: [PATCH v4 1/4] Input: Extract ChromeOS vivaldi physmap show function
Date: Sun, 27 Feb 2022 23:59:21 -0800 [thread overview]
Message-ID: <YhyA2TWIDMld8cq8@google.com> (raw)
In-Reply-To: <20220216195901.1326924-2-swboyd@chromium.org>
Hi Stephen,
On Wed, Feb 16, 2022 at 11:58:58AM -0800, Stephen Boyd wrote:
> diff --git a/include/linux/input/vivaldi-fmap.h b/include/linux/input/vivaldi-fmap.h
> new file mode 100644
> index 000000000000..57563d9da022
> --- /dev/null
> +++ b/include/linux/input/vivaldi-fmap.h
> @@ -0,0 +1,28 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _VIVALDI_KEYMAP_H
> +#define _VIVALDI_KEYMAP_H
> +
> +#include <linux/types.h>
> +
> +#define VIVALDI_MIN_FN_ROW_KEY 1
> +#define VIVALDI_MAX_FN_ROW_KEY 24
These 2 are actually details of HID, we had a #define in atkbd which I
lifted as VIVALDI_MAX_FUNCTION_ROW_KEYS and put here, and dropped it
from atkbd and made cros_ec keyboard driver use it as well.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-02-28 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 19:58 [PATCH v4 0/4] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic Stephen Boyd
2022-02-16 19:58 ` [PATCH v4 1/4] Input: Extract ChromeOS vivaldi physmap show function Stephen Boyd
2022-02-16 22:23 ` Stephen Boyd
2022-02-28 7:59 ` Dmitry Torokhov [this message]
2022-02-16 19:58 ` [PATCH v4 2/4] HID: Extract vivaldi hid feature mapping for use in hid-hammer Stephen Boyd
2022-02-28 8:01 ` Dmitry Torokhov
2022-02-16 19:59 ` [PATCH v4 3/4] HID: google: Add support for vivaldi to hid-hammer Stephen Boyd
2022-02-16 19:59 ` [PATCH v4 4/4] HID: google: modify HID device groups of eel Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhyA2TWIDMld8cq8@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seobrien@chromium.org \
--cc=swboyd@chromium.org \
--cc=xiazhengqiao@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).