From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeff LaBundy <jeff@labundy.com>
Cc: linux-input@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] Input: iqs7222 - avoid dereferencing a NULL pointer
Date: Sun, 17 Apr 2022 16:05:19 -0700 [thread overview]
Message-ID: <YlydL4+m2jhcwMFR@google.com> (raw)
In-Reply-To: <20220417214132.497487-1-jeff@labundy.com>
On Sun, Apr 17, 2022 at 04:41:32PM -0500, Jeff LaBundy wrote:
> Select callers of iqs7222_parse_props() do not expect a child node
> to be derived and returned via pointer. As such, these callers set
> **child_node to NULL. However, this pointer is dereferenced in all
> cases.
>
> To solve this problem, dereference the pointer only for cases that
> expect a child node in the first place. In these cases, the caller
> provides a valid pointer.
>
> Fixes: e505edaedcb9 ("Input: add support for Azoteq IQS7222A/B/C")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2022-04-17 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 21:41 [PATCH] Input: iqs7222 - avoid dereferencing a NULL pointer Jeff LaBundy
2022-04-17 23:05 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlydL4+m2jhcwMFR@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox