* [PATCH] Input: synaptics-rmi4: remove unnecessary flush_workqueue()
@ 2022-04-22 9:33 cgel.zte
2022-04-25 1:23 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-22 9:33 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: ran.jianping, linux-input, linux-kernel, Zeal Robot
From: ran jianping <ran.jianping@zte.com.cn>
All work currently pending will be done first by calling destroy_workqueue,
so there is unnecessary to flush it explicitly.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
drivers/input/rmi4/rmi_f54.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c
index 93b328c796c6..c5ce907535ef 100644
--- a/drivers/input/rmi4/rmi_f54.c
+++ b/drivers/input/rmi4/rmi_f54.c
@@ -733,7 +733,6 @@ static int rmi_f54_probe(struct rmi_function *fn)
v4l2_device_unregister(&f54->v4l2);
remove_wq:
cancel_delayed_work_sync(&f54->work);
- flush_workqueue(f54->workqueue);
destroy_workqueue(f54->workqueue);
return ret;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: synaptics-rmi4: remove unnecessary flush_workqueue()
2022-04-22 9:33 [PATCH] Input: synaptics-rmi4: remove unnecessary flush_workqueue() cgel.zte
@ 2022-04-25 1:23 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2022-04-25 1:23 UTC (permalink / raw)
To: cgel.zte; +Cc: ran.jianping, linux-input, linux-kernel, Zeal Robot
On Fri, Apr 22, 2022 at 09:33:04AM +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is unnecessary to flush it explicitly.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-25 1:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-22 9:33 [PATCH] Input: synaptics-rmi4: remove unnecessary flush_workqueue() cgel.zte
2022-04-25 1:23 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).