From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00246C433EF for ; Mon, 9 May 2022 15:06:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237974AbiEIPKk (ORCPT ); Mon, 9 May 2022 11:10:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237985AbiEIPKj (ORCPT ); Mon, 9 May 2022 11:10:39 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 107562657A for ; Mon, 9 May 2022 08:06:44 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id q23so19891544wra.1 for ; Mon, 09 May 2022 08:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ip-fi.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y4YlizTEUTLQqCEt+JLqAH+3gSJdYyRatSfzlLmy/vU=; b=tR9K9x3da6ovXrt/jaxBw/9e8IQLFQEFEEkgpOUhoXbvqT6mcxMl3dthzpAl+RoVLB eCdUL8SeuzsfJCjaQqRmVntZOt7rtBZzneuekCJ2vuKmbD5MxGo/hhYIamPbXpnOBado 7fV1dGhr5eIQlfl8WAEHNPaWU1nI0Xwb9aPB88LnuKQXni0PZSpeTd0CuBrXYsgtcM27 iIEEXgHt/cSw51A3BYrHK4DAfC3U09fGwvuFKm1Y7jSsxBC6I6C3IumrvDQlXLryL1d6 mAKKZXUICCFBXP3A7tl6ni9x5z7AMpVyHA8UpVnEkJJXtEg9YahTPEc5OUexuGryug4B SefQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y4YlizTEUTLQqCEt+JLqAH+3gSJdYyRatSfzlLmy/vU=; b=zEwCGjI60NgSUf1dzHYK1dy1QhNziefaUnaq7aLwSyODofnKK+si4mdgntLEyG1+yu lXch6sWG8EAcet99LFbZjL3c9ilOxui5dGM6/HNPjACEkNqEDMWREL0NisuaYJyzv17P rSFWbI2RGXSi1vxty6wvkDlfMFNQONpjDC0aijO32wWw/GOZ5mc6a1SS9FOMPKVulCqg KmluzajkcNimn+1/AhJb3caF+tO0VzyBToeP2Pmn2PtWamGulTKtu/fDBXCfdK5e/qX8 Ngkhg7Iqs/jmCxJdxuqhrNpD4nJn6dZtsXM+5nulrm4XKhm6udpLIU52WQvSHD5Y+bKP 4JZg== X-Gm-Message-State: AOAM532uyce0CqOeP5c6ThtWkd5WwX8m/u/+ya7bP5mEcH1ydt7XkbDu nc8IRl3BzMyZx0he3Gej/bMfKg== X-Google-Smtp-Source: ABdhPJyMZ+++4iKGB3yQTV4zDC6ujkkzagjlvu6uwuGAO44YBv/itLTvZ/JZPBwx+ZLS6zNcNoaBKg== X-Received: by 2002:adf:f6c1:0:b0:20a:c408:4aeb with SMTP id y1-20020adff6c1000000b0020ac4084aebmr14178690wrp.74.1652108802598; Mon, 09 May 2022 08:06:42 -0700 (PDT) Received: from debian ([91.193.4.92]) by smtp.gmail.com with ESMTPSA id f8-20020a7bc8c8000000b00394615cf468sm13947241wml.28.2022.05.09.08.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 08:06:42 -0700 (PDT) Date: Mon, 9 May 2022 17:06:39 +0200 From: Johan Boger To: Joe Perches Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: drivers: hid: hid-asus.c: Optimized input logic for keys Message-ID: References: <20220509100258.24764-1-jb@ip.fi> <5e44ef1302b722d3bf7fafe55111e76f7173e6be.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e44ef1302b722d3bf7fafe55111e76f7173e6be.camel@perches.com> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, May 09, 2022 at 06:54:51AM -0700, Joe Perches wrote: > On Mon, 2022-05-09 at 12:02 +0200, Johan Boger wrote: > > Instead of calling asus_map_key_clear() function in each case, > > we now set a temporary value and clear it after default. > > Patch was checked by checkpatch and adjusted accordingly. > > This patch subject is not correct. This is not a staging patch. > > Your commit message is also incomplete as this is modifying comments, > changing whitespace, and changing brace styles. > > and IMO: > > Either use a single line case style like: > > case foo: statement; break; > > or use a multiple line case style like: > > case foo: > statement; > break; > > but please do not use a mixed case one line and statement; break; > on another like: > > case foo: > statement; break; > > Please remember checkpatch is only a guide, it's not the last word > on style where every message it emits requires an actual code change. > > btw: there are _many_ single line case uses in the kernel > > $ git grep -P 'case\s+\w+\s*:\s*\w+' -- '*.[ch]' | wc -l > 7581 > > > Ok. Thanks for helping me out. Will resend when I have made sure it's up to standards. Your time and guidance is appreciated.