Re: [PATCH v2] HID: usbhid: set mouse as a wakeup resource

Limonciello, Mario
2022-06-17T17:44:56Z

On 6/17/2022 12:39, 'Alan Stern' wrote:
> On Fri, Jun 17, 2022 at 11:06:05AM -0500, Limonciello, Mario wrote:
>> On 6/17/2022 10:39, David Laight wrote:
>>> From: Alan Stern
>>>> Sent: 17 June 2022 16:05
>>> ...
>>>> Another issue is whether wakeup for a mouse means pressing a button or
>>>> just moving the mouse. For a mouse that uses LEDs to sense motion,
>>>> moving it won't generate a wakeup request -- USB suspend does not allow
>>>> the mouse to use enough current to keep the LEDs illuminated. On the
>>>> other hand, there's no reason why wakeup by pressing a button shouldn't
>>>> always work.
>>>
>>
>> At least one of the Logitech wireless mice I have here works to wake either
>> by clicking the buttons or moving the mouse, presumably because the mouse is
>> battery powered. One of my wired ones works only by clicking (which is as
>> you describe).
>>
>> I don't believe there is going to be a way to have granularity of which type
>> of event will wake the system; it will be hardware dependent.
>
> Precisely. So if the point of the patch is to match users'
> expectations, and some users expect to be able to wake up their systems
> by moving the mouse but their mouse is like yours, then the situation is
> hopeless and the patch won't help.
>
>>> I'm not even sure I want a system to wake up because it's mouse
>>> gets knocked.
>>> I guess a mouse could include accelerometers so that you can shake it!
>>>
>>
>> I'm completely opposite. As soon as I sit down at my desk which has a a
>> closed docked laptop, the first thing I do is use the mouse which will wake
>> the system.
>>
>> And if you take a step further and consider desktops if you *don't* do this
>> you'll have to find your power button or use the keyboard.
>
> The usual counterexample is laptop-in-a-knapsack. You don't want the
> laptop to wake up just because the knapsack was picked up and that
> jostled the mouse.

But who puts their laptop into their bag with a USB mouse plugged in?

I could see leaving your Logitech dongle plugged in and forgetting to
turn off the mouse before you tossed it in your bag. However, the same
problem can happen with a travel USB keyboard you forgot to turn off.
That's already set to wakeup by default today.

>
> Overall, it seems like this patch needs a better justification.
>
> Alan Stern
>
>>> I've an idea that one of my systems manages to boot if the mouse
>>> is knocked (and it was last shutdown from windows).
>>> At least, that it why I think it is sometimes booting up.
>>>
>>
>> It was probably hibernated from Windows rather than shutdown. Windows tends
>> to make this "invisible" to the user. Some systems can wake from S4 on
>> certain devices, and I would expect some registers on your system have been
>> programmed to work that way.