From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: margeyang <marge.yang@synaptics.corp-partner.google.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
hdegoede@redhat.com, benjamin.tissoires@redhat.com,
marge.yang@tw.synaptics.com, derek.cheng@tw.synaptics.com,
vincent.huang@tw.synaptics.com
Subject: Re: [PATCH V2] Input: synaptics-rmi4 - filter incomplete relative packet.
Date: Fri, 12 Aug 2022 12:28:18 -0700 [thread overview]
Message-ID: <Yvap0uh1U81gqy6J@google.com> (raw)
In-Reply-To: <1660293805-16053-1-git-send-email-marge.yang@synaptics.corp-partner.google.com>
Hi Marge,
On Fri, Aug 12, 2022 at 04:43:25PM +0800, margeyang wrote:
> From: Marge Yang <marge.yang@synaptics.corp-partner.google.com>
>
> RMI4 F03 supports the Stick function,
> it's designed to support relative packet.
> This patch supports the following case.
> When relative packet can't be reported completely,
> it may miss one byte or two byte.
> New Synaptics firmware will report PARITY error.
> When timeout error or parity error happens,
> RMI4 driver will sends 0xFE command and
> ask FW to Re-send stick packet again.
My understanding is that F03 is intended to be a pass-through mechanism
for PS/2-compatible devices. In that spirit all protocol handling and
validation should happen in psmouse driver that attaches to a serio port
provided by F03.
Historically we did not pay attention to parity and frame errors for
PS/2 mice/touchpads (and for keyboards on x86) but we coudl add such
code there. Do we actually observe this with RMI devices? Can RMI
firmware handle this better instead?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-08-12 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 8:43 [PATCH V2] Input: synaptics-rmi4 - filter incomplete relative packet margeyang
2022-08-12 10:37 ` Hans de Goede
2022-08-15 9:44 ` Marge Yang
2022-08-12 19:28 ` Dmitry Torokhov [this message]
2022-08-15 6:49 ` Marge Yang
2022-08-30 9:59 ` Marge Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvap0uh1U81gqy6J@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=derek.cheng@tw.synaptics.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marge.yang@synaptics.corp-partner.google.com \
--cc=marge.yang@tw.synaptics.com \
--cc=vincent.huang@tw.synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).