linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] input: misc: rk805-pwrkey: Fix module autoloading
@ 2022-06-12 22:54 Peter Robinson
  2022-06-13 17:03 ` Javier Martinez Canillas
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Peter Robinson @ 2022-06-12 22:54 UTC (permalink / raw)
  To: Dmitry Torokhov, Joseph Chen, linux-input; +Cc: Peter Robinson

Add the module alias so the rk805-pwrkey driver will
autoload when built as a module.

Fixes: 5a35b85c2d92 ("Input: add power key driver for Rockchip RK805 PMIC")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/input/misc/rk805-pwrkey.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/misc/rk805-pwrkey.c b/drivers/input/misc/rk805-pwrkey.c
index 3fb64dbda1a2..76873aa005b4 100644
--- a/drivers/input/misc/rk805-pwrkey.c
+++ b/drivers/input/misc/rk805-pwrkey.c
@@ -98,6 +98,7 @@ static struct platform_driver rk805_pwrkey_driver = {
 };
 module_platform_driver(rk805_pwrkey_driver);
 
+MODULE_ALIAS("platform:rk805-pwrkey");
 MODULE_AUTHOR("Joseph Chen <chenjh@rock-chips.com>");
 MODULE_DESCRIPTION("RK805 PMIC Power Key driver");
 MODULE_LICENSE("GPL");
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] input: misc: rk805-pwrkey: Fix module autoloading
  2022-06-12 22:54 [PATCH] input: misc: rk805-pwrkey: Fix module autoloading Peter Robinson
@ 2022-06-13 17:03 ` Javier Martinez Canillas
  2022-08-22  7:18 ` Peter Robinson
  2022-08-23  4:27 ` Dmitry Torokhov
  2 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2022-06-13 17:03 UTC (permalink / raw)
  To: Peter Robinson, Dmitry Torokhov, Joseph Chen, linux-input

Hello Peter,

On 6/13/22 00:54, Peter Robinson wrote:
> Add the module alias so the rk805-pwrkey driver will
> autoload when built as a module.
> 
> Fixes: 5a35b85c2d92 ("Input: add power key driver for Rockchip RK805 PMIC")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] input: misc: rk805-pwrkey: Fix module autoloading
  2022-06-12 22:54 [PATCH] input: misc: rk805-pwrkey: Fix module autoloading Peter Robinson
  2022-06-13 17:03 ` Javier Martinez Canillas
@ 2022-08-22  7:18 ` Peter Robinson
  2022-08-23  4:27 ` Dmitry Torokhov
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Robinson @ 2022-08-22  7:18 UTC (permalink / raw)
  To: Dmitry Torokhov, Joseph Chen, linux-input

Hi,

Any chance someone could review and pick this up please?

Peter

On Sun, Jun 12, 2022 at 11:54 PM Peter Robinson <pbrobinson@gmail.com> wrote:
>
> Add the module alias so the rk805-pwrkey driver will
> autoload when built as a module.
>
> Fixes: 5a35b85c2d92 ("Input: add power key driver for Rockchip RK805 PMIC")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  drivers/input/misc/rk805-pwrkey.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/rk805-pwrkey.c b/drivers/input/misc/rk805-pwrkey.c
> index 3fb64dbda1a2..76873aa005b4 100644
> --- a/drivers/input/misc/rk805-pwrkey.c
> +++ b/drivers/input/misc/rk805-pwrkey.c
> @@ -98,6 +98,7 @@ static struct platform_driver rk805_pwrkey_driver = {
>  };
>  module_platform_driver(rk805_pwrkey_driver);
>
> +MODULE_ALIAS("platform:rk805-pwrkey");
>  MODULE_AUTHOR("Joseph Chen <chenjh@rock-chips.com>");
>  MODULE_DESCRIPTION("RK805 PMIC Power Key driver");
>  MODULE_LICENSE("GPL");
> --
> 2.36.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] input: misc: rk805-pwrkey: Fix module autoloading
  2022-06-12 22:54 [PATCH] input: misc: rk805-pwrkey: Fix module autoloading Peter Robinson
  2022-06-13 17:03 ` Javier Martinez Canillas
  2022-08-22  7:18 ` Peter Robinson
@ 2022-08-23  4:27 ` Dmitry Torokhov
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2022-08-23  4:27 UTC (permalink / raw)
  To: Peter Robinson; +Cc: Joseph Chen, linux-input

On Sun, Jun 12, 2022 at 11:54:37PM +0100, Peter Robinson wrote:
> Add the module alias so the rk805-pwrkey driver will
> autoload when built as a module.
> 
> Fixes: 5a35b85c2d92 ("Input: add power key driver for Rockchip RK805 PMIC")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-23  4:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-12 22:54 [PATCH] input: misc: rk805-pwrkey: Fix module autoloading Peter Robinson
2022-06-13 17:03 ` Javier Martinez Canillas
2022-08-22  7:18 ` Peter Robinson
2022-08-23  4:27 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).