From: Lee Jones <lee@kernel.org>
To: Silvan Jegen <s.jegen@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [RESEND] HID: steam: Prevent NULL pointer dereference in steam_{recv,send}_report
Date: Mon, 12 Sep 2022 14:04:15 +0100 [thread overview]
Message-ID: <Yx8uT8UEK5GjOOaE@google.com> (raw)
In-Reply-To: <3HW30DP4UX94G.2T1G25E825X7D@homearch.localdomain>
On Mon, 12 Sep 2022, Silvan Jegen wrote:
> Hi
>
> Lee Jones <lee@kernel.org> wrote:
> > On Wed, 03 Aug 2022, Lee Jones wrote:
> >
> > > It is possible for a malicious device to forgo submitting a Feature
> > > Report. The HID Steam driver presently makes no prevision for this
> > > and de-references the 'struct hid_report' pointer obtained from the
> > > HID devices without first checking its validity. Let's change that.
> >
> > This patch has been floating around since the beginning of July.
> >
> > It fixes a real issue which was found by creating a virtual
> > (software based) malicious device and registering it as a HID device.
> >
> > There is nothing preventing a real attacker from creating a H/W
> > version of the device in order to instigate an out-of-bounds read,
> > potentially leading to a data leak.
> >
> > Would someone be kind enough to review please?
>
> AFACT this patch has been applied by Jiri on the 25th of August already.
Ah, I missed his reply to the original patch.
> Is a review still needed in this case?
Certainly not. Thank you for your reply.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2022-09-12 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 11:18 [RESEND] HID: steam: Prevent NULL pointer dereference in steam_{recv,send}_report Lee Jones
2022-09-12 11:47 ` Lee Jones
2022-09-12 12:31 ` Silvan Jegen
2022-09-12 13:04 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx8uT8UEK5GjOOaE@google.com \
--to=lee@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.jegen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).