From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: atkbd - switch to using dev_groups for driver-specific attributes
Date: Sat, 3 Sep 2022 07:51:57 +0200 [thread overview]
Message-ID: <YxLrfVjnOy8JdzN6@kroah.com> (raw)
In-Reply-To: <20220903051119.1332808-1-dmitry.torokhov@gmail.com>
On Fri, Sep 02, 2022 at 10:11:17PM -0700, Dmitry Torokhov wrote:
> The driver core now has the ability to handle the creation and removal
> of device-specific sysfs files, let's use it instead of registering and
> unregistering attributes by hand.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/keyboard/atkbd.c | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
Wow, I had missed these in my searches as I didn't think any drivers
would be using sysfs_create_groups(), thanks for noticing them and
cleaning these up.
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2022-09-03 5:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 5:11 [PATCH 1/3] Input: atkbd - switch to using dev_groups for driver-specific attributes Dmitry Torokhov
2022-09-03 5:11 ` [PATCH 2/3] Input: psmouse " Dmitry Torokhov
2022-09-03 5:52 ` Greg Kroah-Hartman
2022-09-03 5:11 ` [PATCH 3/3] Input: aiptek " Dmitry Torokhov
2022-09-03 5:52 ` Greg Kroah-Hartman
2022-09-03 5:51 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxLrfVjnOy8JdzN6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox