From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] Input: matrix_keypad - replace header inclusions by forward declarations
Date: Mon, 26 Sep 2022 13:56:58 +0300 [thread overview]
Message-ID: <YzGFevZg149db377@smile.fi.intel.com> (raw)
In-Reply-To: <YzGFWt40IhkASq4j@smile.fi.intel.com>
On Mon, Sep 26, 2022 at 01:56:27PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 23, 2022 at 12:03:00PM -0700, Dmitry Torokhov wrote:
> > On Fri, Sep 23, 2022 at 09:46:32PM +0300, Andy Shevchenko wrote:
> > > When the data structure is only referred by pointer, compiler may not need
> > > to see the contents of the data type. Thus, we may replace header inclusions
> > > by respective forward declarations.
...
> > > +struct device;
> > > +struct input_dev;
> >
> > This results in a ton of compile errors. While I believe this change is
> > a good one, we need to fix users of this include first.
>
> Indeed, sorry for breaking things (I compile-tested with limited drivers
> enabled). I will look into LKP reports and will fix the users.
Ah, thanks, I see your series for that!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-26 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 18:46 [PATCH v1 1/2] Input: matrix_keypad - add missed header inclusion Andy Shevchenko
2022-09-23 18:46 ` [PATCH v1 2/2] Input: matrix_keypad - replace header inclusions by forward declarations Andy Shevchenko
2022-09-23 19:03 ` Dmitry Torokhov
2022-09-26 10:56 ` Andy Shevchenko
2022-09-26 10:56 ` Andy Shevchenko [this message]
2022-10-29 14:25 ` Guenter Roeck
2022-10-29 22:28 ` Dmitry Torokhov
2022-10-29 23:02 ` Guenter Roeck
2022-10-30 4:33 ` Dmitry Torokhov
2022-10-30 4:55 ` Guenter Roeck
2022-09-23 19:01 ` [PATCH v1 1/2] Input: matrix_keypad - add missed header inclusion Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzGFevZg149db377@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).