linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chris Morgan <macromorgan@hotmail.com>
Cc: Chris Morgan <macroalpha82@gmail.com>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	rydberg@bitmath.org, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org
Subject: Re: [PATCH 3/3] input/touchscreen: Add Hynitron cstxxx touchscreen
Date: Fri, 30 Sep 2022 08:38:03 -0700	[thread overview]
Message-ID: <YzcNW/ZVV/KMqpds@google.com> (raw)
In-Reply-To: <SN6PR06MB5342901F1E899851B6D9670CA5569@SN6PR06MB5342.namprd06.prod.outlook.com>

On Fri, Sep 30, 2022 at 10:34:50AM -0500, Chris Morgan wrote:
> On Thu, Sep 29, 2022 at 09:24:27AM -0700, Dmitry Torokhov wrote:
> > Hi Chris,
> > 
> > On Wed, Sep 28, 2022 at 04:48:06PM -0500, Chris Morgan wrote:
> > > +
> > > +	/*
> > > +	 * Testing suggests command is required to allow reading of
> > > +	 * firmware registers.
> > > +	 */
> > > +	buf[0] = 0xd1;
> > > +	buf[1] = 0x01;
> > 
> > I wonder if we can define some symbolic names for these.
> > 
> 
> I don't know what they mean, the best I can do is guess. No
> datasheet sadly. I know from preliminary testing if I don't
> send this initial command here the rest of them fail, so I
> assume this command allows me to read certain registers?

Guessing is fine, we can adjust them if we ever get a hold of the data
sheet.

Thanks.

-- 
Dmitry

      reply	other threads:[~2022-09-30 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 21:48 [PATCH 0/3] Add Hynitron cstxxx Touchscreen Chris Morgan
2022-09-28 21:48 ` [PATCH 1/3] dt-bindings: vendor-prefixes: add Hynitron vendor prefix Chris Morgan
2022-09-30 10:51   ` Krzysztof Kozlowski
2022-09-28 21:48 ` [PATCH 2/3] dt-bindings: input: touchscreen: Add Hynitron cstxxx bindings Chris Morgan
2022-09-30 10:54   ` Krzysztof Kozlowski
2022-09-30 15:21     ` Chris Morgan
2022-09-30 16:32       ` Krzysztof Kozlowski
2022-09-28 21:48 ` [PATCH 3/3] input/touchscreen: Add Hynitron cstxxx touchscreen Chris Morgan
2022-09-29 16:24   ` Dmitry Torokhov
2022-09-30 15:34     ` Chris Morgan
2022-09-30 15:38       ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzcNW/ZVV/KMqpds@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).