linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: fnkl.kernel@gmail.com
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Janne Grunau <j@jannau.net>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/4] Driver for Apple Z2 touchscreens.
Date: Tue, 26 Nov 2024 17:51:42 -0800	[thread overview]
Message-ID: <Z0Z7Lrv3rBfzac_e@google.com> (raw)
In-Reply-To: <20241126-z2-v1-0-c43c4cc6200d@gmail.com>

Hi Sasha,

On Tue, Nov 26, 2024 at 09:47:58PM +0100, Sasha Finkelstein via B4 Relay wrote:
> Hi.
> 
> This series adds support for Apple touchscreens using the Z2 protocol.
> Those are used as the primary touchscreen on mobile Apple devices, and for the
> touchbar on laptops using the M-series chips. (T1/T2 laptops have a coprocessor
> in charge of speaking Z2 to the touchbar).
> 
> Originally sent as a RFC at https://lore.kernel.org/all/20230223-z2-for-ml-v1-0-028f2b85dc15@gmail.com/
> The changes since then mostly address the review feedback, but also
> add another machine that has this specific controller.
> 
> The extra gpio needed to be toggled turned out to be a quirk of the
> j293, normal CS is unusable on it, and a gpio has to be used instead.
> (j493 does not have this quirk)

I believe this needs to be done at the SPI controller level. See
"cs-gpiods" property in
Documentation/devicetree/bindings/spi/spi-controller.yaml that, as far
as I understand, allows overriding controller's native CS handling with
a GPIO when needed.

Cc-ing Mark Brown.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2024-11-27  1:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26 20:47 [PATCH 0/4] Driver for Apple Z2 touchscreens Sasha Finkelstein via B4 Relay
2024-11-26 20:47 ` [PATCH 1/4] dt-bindings: input: touchscreen: Add Z2 controller Sasha Finkelstein via B4 Relay
2024-11-27  8:46   ` Krzysztof Kozlowski
2024-11-27 10:33     ` Krzysztof Kozlowski
2024-11-27 10:49     ` Sasha Finkelstein
2024-11-27 11:23       ` Sasha Finkelstein
2024-11-27 12:03         ` Krzysztof Kozlowski
2024-11-26 20:48 ` [PATCH 2/4] input: apple_z2: Add a driver for Apple Z2 touchscreens Sasha Finkelstein via B4 Relay
2024-11-27  2:22   ` Dmitry Torokhov
2024-11-27  8:24     ` Sasha Finkelstein
2024-11-27 19:59       ` Dmitry Torokhov
2024-11-27  9:00   ` Krzysztof Kozlowski
2024-11-27 10:19     ` Sasha Finkelstein
2024-11-27 10:22       ` Dmitry Torokhov
2024-11-27 10:25         ` Krzysztof Kozlowski
2024-11-26 20:48 ` [PATCH 3/4] arm64: dts: apple: Add touchbar digitizer nodes Sasha Finkelstein via B4 Relay
2024-11-26 21:14   ` Janne Grunau
2024-11-27  8:55   ` Krzysztof Kozlowski
2024-11-27 10:31     ` Sasha Finkelstein
2024-11-27 10:34       ` Krzysztof Kozlowski
2024-11-26 20:48 ` [PATCH 4/4] MAINTAINERS: Add entries for Apple Z2 touchscreen driver Sasha Finkelstein via B4 Relay
2024-11-27  1:51 ` Dmitry Torokhov [this message]
2024-11-27  8:29   ` [PATCH 0/4] Driver for Apple Z2 touchscreens Sasha Finkelstein
2024-11-27 15:29     ` Hector Martin
2024-11-27 16:20       ` Hector Martin
2024-11-28  8:37         ` Janne Grunau
2024-11-27 10:27 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0Z7Lrv3rBfzac_e@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fnkl.kernel@gmail.com \
    --cc=j@jannau.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=robh@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=sven@svenpeter.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).