From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Nilton Perim Neto <niltonperimneto@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: xpad - three devices added
Date: Mon, 3 Feb 2025 07:22:05 -0800 [thread overview]
Message-ID: <Z6DfHWLTDgPgoGO9@google.com> (raw)
In-Reply-To: <2025012328-audience-tucking-405d@gregkh>
On Thu, Jan 23, 2025 at 07:04:58AM +0100, Greg KH wrote:
> On Wed, Jan 22, 2025 at 06:47:07PM -0300, Nilton Perim Neto wrote:
> > Added to the xpad driver the following controllers:
> > 8BitDo SN30 Pro, Hyperkin X91 and Gamesir G7 SE
> > Also changed the VIDs to better describe them
>
> When you say "also" that's a huge hint that this should be broken up
> into multiple patches, right? Renaming an id has nothing to do with
> adding a new one.
It was a bad wording. Vendor macros were not changed, only comments were
updated to reflect the fact that some of the macros cover more than
a single controller. It does not make sense to split this apart.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2025-02-03 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 21:47 [PATCH] Input: xpad - three devices added Nilton Perim Neto
2025-01-23 6:04 ` Greg KH
2025-02-03 15:22 ` Dmitry Torokhov [this message]
2025-02-03 15:17 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6DfHWLTDgPgoGO9@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=niltonperimneto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).