From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 1/4] Input: st-keyscan: drop of_match_ptr for ID table
Date: Fri, 17 Mar 2023 04:19:52 -0700 [thread overview]
Message-ID: <ZBRM2GPgh9u5PJaS@google.com> (raw)
In-Reply-To: <20230312131514.351603-1-krzysztof.kozlowski@linaro.org>
On Sun, Mar 12, 2023 at 02:15:11PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/input/keyboard/st-keyscan.c:251:34: error: ‘keyscan_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2023-03-17 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 13:15 [PATCH 1/4] Input: st-keyscan: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-12 13:15 ` [PATCH 2/4] Input: tm2-touchkey: " Krzysztof Kozlowski
2023-03-17 11:20 ` Dmitry Torokhov
2023-03-12 13:15 ` [PATCH 3/4] Input: sun4i-ts: " Krzysztof Kozlowski
2023-03-14 20:04 ` Jernej Škrabec
2023-03-17 11:20 ` Dmitry Torokhov
2023-03-12 13:15 ` [PATCH 4/4] Input: bcm_iproc_tsc: " Krzysztof Kozlowski
2023-03-17 11:20 ` Dmitry Torokhov
2023-03-17 11:19 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBRM2GPgh9u5PJaS@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=rjui@broadcom.com \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).