* [PATCH 2/4] Input: tm2-touchkey: drop of_match_ptr for ID table
2023-03-12 13:15 [PATCH 1/4] Input: st-keyscan: drop of_match_ptr for ID table Krzysztof Kozlowski
@ 2023-03-12 13:15 ` Krzysztof Kozlowski
2023-03-17 11:20 ` Dmitry Torokhov
2023-03-12 13:15 ` [PATCH 3/4] Input: sun4i-ts: " Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-12 13:15 UTC (permalink / raw)
To: Dmitry Torokhov, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, linux-input, linux-kernel,
linux-arm-kernel, linux-sunxi
Cc: Krzysztof Kozlowski
The driver will match mostly by DT table (even thought there is regular
ID table) so there is little benefit in of_match_ptr (this also allows
ACPI matching via PRP0001, even though it might not be relevant here).
This also fixes !CONFIG_OF error:
drivers/input/keyboard/tm2-touchkey.c:335:34: error: ‘tm2_touchkey_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/input/keyboard/tm2-touchkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tm2-touchkey.c b/drivers/input/keyboard/tm2-touchkey.c
index 6627e65f06e5..4e20571cb4c3 100644
--- a/drivers/input/keyboard/tm2-touchkey.c
+++ b/drivers/input/keyboard/tm2-touchkey.c
@@ -354,7 +354,7 @@ static struct i2c_driver tm2_touchkey_driver = {
.driver = {
.name = TM2_TOUCHKEY_DEV_NAME,
.pm = pm_sleep_ptr(&tm2_touchkey_pm_ops),
- .of_match_table = of_match_ptr(tm2_touchkey_of_match),
+ .of_match_table = tm2_touchkey_of_match,
},
.probe_new = tm2_touchkey_probe,
.id_table = tm2_touchkey_id_table,
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/4] Input: tm2-touchkey: drop of_match_ptr for ID table
2023-03-12 13:15 ` [PATCH 2/4] Input: tm2-touchkey: " Krzysztof Kozlowski
@ 2023-03-17 11:20 ` Dmitry Torokhov
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2023-03-17 11:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ray Jui, Scott Branden, Broadcom internal kernel review list,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-input,
linux-kernel, linux-arm-kernel, linux-sunxi
On Sun, Mar 12, 2023 at 02:15:12PM +0100, Krzysztof Kozlowski wrote:
> The driver will match mostly by DT table (even thought there is regular
> ID table) so there is little benefit in of_match_ptr (this also allows
> ACPI matching via PRP0001, even though it might not be relevant here).
> This also fixes !CONFIG_OF error:
>
> drivers/input/keyboard/tm2-touchkey.c:335:34: error: ‘tm2_touchkey_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/4] Input: sun4i-ts: drop of_match_ptr for ID table
2023-03-12 13:15 [PATCH 1/4] Input: st-keyscan: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-12 13:15 ` [PATCH 2/4] Input: tm2-touchkey: " Krzysztof Kozlowski
@ 2023-03-12 13:15 ` Krzysztof Kozlowski
2023-03-14 20:04 ` Jernej Škrabec
2023-03-17 11:20 ` Dmitry Torokhov
2023-03-12 13:15 ` [PATCH 4/4] Input: bcm_iproc_tsc: " Krzysztof Kozlowski
2023-03-17 11:19 ` [PATCH 1/4] Input: st-keyscan: " Dmitry Torokhov
3 siblings, 2 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-12 13:15 UTC (permalink / raw)
To: Dmitry Torokhov, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, linux-input, linux-kernel,
linux-arm-kernel, linux-sunxi
Cc: Krzysztof Kozlowski
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here). This
also fixes !CONFIG_OF error:
drivers/input/touchscreen/sun4i-ts.c:392:34: error: ‘sun4i_ts_of_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/input/touchscreen/sun4i-ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c
index 1117fba30020..577c75c83e25 100644
--- a/drivers/input/touchscreen/sun4i-ts.c
+++ b/drivers/input/touchscreen/sun4i-ts.c
@@ -400,7 +400,7 @@ MODULE_DEVICE_TABLE(of, sun4i_ts_of_match);
static struct platform_driver sun4i_ts_driver = {
.driver = {
.name = "sun4i-ts",
- .of_match_table = of_match_ptr(sun4i_ts_of_match),
+ .of_match_table = sun4i_ts_of_match,
},
.probe = sun4i_ts_probe,
.remove = sun4i_ts_remove,
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/4] Input: sun4i-ts: drop of_match_ptr for ID table
2023-03-12 13:15 ` [PATCH 3/4] Input: sun4i-ts: " Krzysztof Kozlowski
@ 2023-03-14 20:04 ` Jernej Škrabec
2023-03-17 11:20 ` Dmitry Torokhov
1 sibling, 0 replies; 9+ messages in thread
From: Jernej Škrabec @ 2023-03-14 20:04 UTC (permalink / raw)
To: Dmitry Torokhov, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Chen-Yu Tsai,
Samuel Holland, linux-input, linux-kernel, linux-arm-kernel,
linux-sunxi, Krzysztof Kozlowski
Cc: Krzysztof Kozlowski
Dne nedelja, 12. marec 2023 ob 14:15:13 CET je Krzysztof Kozlowski napisal(a):
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/input/touchscreen/sun4i-ts.c:392:34: error: ‘sun4i_ts_of_match’
> defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/input/touchscreen/sun4i-ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> diff --git a/drivers/input/touchscreen/sun4i-ts.c
> b/drivers/input/touchscreen/sun4i-ts.c index 1117fba30020..577c75c83e25
> 100644
> --- a/drivers/input/touchscreen/sun4i-ts.c
> +++ b/drivers/input/touchscreen/sun4i-ts.c
> @@ -400,7 +400,7 @@ MODULE_DEVICE_TABLE(of, sun4i_ts_of_match);
> static struct platform_driver sun4i_ts_driver = {
> .driver = {
> .name = "sun4i-ts",
> - .of_match_table = of_match_ptr(sun4i_ts_of_match),
> + .of_match_table = sun4i_ts_of_match,
> },
> .probe = sun4i_ts_probe,
> .remove = sun4i_ts_remove,
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 3/4] Input: sun4i-ts: drop of_match_ptr for ID table
2023-03-12 13:15 ` [PATCH 3/4] Input: sun4i-ts: " Krzysztof Kozlowski
2023-03-14 20:04 ` Jernej Škrabec
@ 2023-03-17 11:20 ` Dmitry Torokhov
1 sibling, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2023-03-17 11:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ray Jui, Scott Branden, Broadcom internal kernel review list,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-input,
linux-kernel, linux-arm-kernel, linux-sunxi
On Sun, Mar 12, 2023 at 02:15:13PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/input/touchscreen/sun4i-ts.c:392:34: error: ‘sun4i_ts_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/4] Input: bcm_iproc_tsc: drop of_match_ptr for ID table
2023-03-12 13:15 [PATCH 1/4] Input: st-keyscan: drop of_match_ptr for ID table Krzysztof Kozlowski
2023-03-12 13:15 ` [PATCH 2/4] Input: tm2-touchkey: " Krzysztof Kozlowski
2023-03-12 13:15 ` [PATCH 3/4] Input: sun4i-ts: " Krzysztof Kozlowski
@ 2023-03-12 13:15 ` Krzysztof Kozlowski
2023-03-17 11:20 ` Dmitry Torokhov
2023-03-17 11:19 ` [PATCH 1/4] Input: st-keyscan: " Dmitry Torokhov
3 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-12 13:15 UTC (permalink / raw)
To: Dmitry Torokhov, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, linux-input, linux-kernel,
linux-arm-kernel, linux-sunxi
Cc: Krzysztof Kozlowski
The driver can match only via the DT table so the table should be always
used and the of_match_ptr does not have any sense (this also allows ACPI
matching via PRP0001, even though it might not be relevant here). This
also fixes !CONFIG_OF error:
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/input/touchscreen/bcm_iproc_tsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c b/drivers/input/touchscreen/bcm_iproc_tsc.c
index 35e2fe9911a4..9c84235327bf 100644
--- a/drivers/input/touchscreen/bcm_iproc_tsc.c
+++ b/drivers/input/touchscreen/bcm_iproc_tsc.c
@@ -511,7 +511,7 @@ static struct platform_driver iproc_ts_driver = {
.probe = iproc_ts_probe,
.driver = {
.name = IPROC_TS_NAME,
- .of_match_table = of_match_ptr(iproc_ts_of_match),
+ .of_match_table = iproc_ts_of_match,
},
};
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 4/4] Input: bcm_iproc_tsc: drop of_match_ptr for ID table
2023-03-12 13:15 ` [PATCH 4/4] Input: bcm_iproc_tsc: " Krzysztof Kozlowski
@ 2023-03-17 11:20 ` Dmitry Torokhov
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2023-03-17 11:20 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ray Jui, Scott Branden, Broadcom internal kernel review list,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-input,
linux-kernel, linux-arm-kernel, linux-sunxi
On Sun, Mar 12, 2023 at 02:15:14PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] Input: st-keyscan: drop of_match_ptr for ID table
2023-03-12 13:15 [PATCH 1/4] Input: st-keyscan: drop of_match_ptr for ID table Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-03-12 13:15 ` [PATCH 4/4] Input: bcm_iproc_tsc: " Krzysztof Kozlowski
@ 2023-03-17 11:19 ` Dmitry Torokhov
3 siblings, 0 replies; 9+ messages in thread
From: Dmitry Torokhov @ 2023-03-17 11:19 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Ray Jui, Scott Branden, Broadcom internal kernel review list,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, linux-input,
linux-kernel, linux-arm-kernel, linux-sunxi
On Sun, Mar 12, 2023 at 02:15:11PM +0100, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here). This
> also fixes !CONFIG_OF error:
>
> drivers/input/keyboard/st-keyscan.c:251:34: error: ‘keyscan_of_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread