* Re: [PATCH] Input: iforce - Fix exception handling in iforce_usb_probe() [not found] ` <521b63e1-9470-58ef-599e-50a1846e5380@web.de> @ 2023-03-20 4:21 ` Dmitry Torokhov 2023-03-20 4:34 ` Tetsuo Handa 0 siblings, 1 reply; 3+ messages in thread From: Dmitry Torokhov @ 2023-03-20 4:21 UTC (permalink / raw) To: Markus Elfring Cc: kernel-janitors, linux-input, Hillf Danton, Tetsuo Handa, cocci, LKML On Sun, Mar 19, 2023 at 07:03:00PM +0100, Markus Elfring wrote: > Date: Sun, 19 Mar 2023 18:50:51 +0100 > > The label “fail” was used to jump to another pointer check despite of > the detail in the implementation of the function “iforce_usb_probe” > that it was determined already that a corresponding variable contained > still a null pointer. > > 1. Use more appropriate labels instead. > > 2. Reorder jump targets at the end. > > 3. Delete a redundant check. > > > This issue was detected by using the Coccinelle software. I am sorry, but I do not understand what the actual issue is. The fact that come Coccinelle script complains is not enough to change the code. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: iforce - Fix exception handling in iforce_usb_probe() 2023-03-20 4:21 ` [PATCH] Input: iforce - Fix exception handling in iforce_usb_probe() Dmitry Torokhov @ 2023-03-20 4:34 ` Tetsuo Handa 2023-03-20 6:05 ` Dmitry Torokhov 0 siblings, 1 reply; 3+ messages in thread From: Tetsuo Handa @ 2023-03-20 4:34 UTC (permalink / raw) To: Dmitry Torokhov, Markus Elfring Cc: kernel-janitors, linux-input, Hillf Danton, cocci, LKML On 2023/03/20 13:21, Dmitry Torokhov wrote: > On Sun, Mar 19, 2023 at 07:03:00PM +0100, Markus Elfring wrote: >> Date: Sun, 19 Mar 2023 18:50:51 +0100 >> >> The label “fail” was used to jump to another pointer check despite of >> the detail in the implementation of the function “iforce_usb_probe” >> that it was determined already that a corresponding variable contained >> still a null pointer. >> >> 1. Use more appropriate labels instead. >> >> 2. Reorder jump targets at the end. >> >> 3. Delete a redundant check. >> >> >> This issue was detected by using the Coccinelle software. > > I am sorry, but I do not understand what the actual issue is. The fact > that come Coccinelle script complains is not enough to change the code. > Right. There is no issue with the code, for usb_free_urb(NULL) is a no-op. Proposing as a cleanup, without Fixes: tags, could be possible though. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: iforce - Fix exception handling in iforce_usb_probe() 2023-03-20 4:34 ` Tetsuo Handa @ 2023-03-20 6:05 ` Dmitry Torokhov 0 siblings, 0 replies; 3+ messages in thread From: Dmitry Torokhov @ 2023-03-20 6:05 UTC (permalink / raw) To: Tetsuo Handa Cc: Markus Elfring, kernel-janitors, linux-input, Hillf Danton, cocci, LKML On Mon, Mar 20, 2023 at 01:34:52PM +0900, Tetsuo Handa wrote: > On 2023/03/20 13:21, Dmitry Torokhov wrote: > > On Sun, Mar 19, 2023 at 07:03:00PM +0100, Markus Elfring wrote: > >> Date: Sun, 19 Mar 2023 18:50:51 +0100 > >> > >> The label “fail” was used to jump to another pointer check despite of > >> the detail in the implementation of the function “iforce_usb_probe” > >> that it was determined already that a corresponding variable contained > >> still a null pointer. > >> > >> 1. Use more appropriate labels instead. > >> > >> 2. Reorder jump targets at the end. > >> > >> 3. Delete a redundant check. > >> > >> > >> This issue was detected by using the Coccinelle software. > > > > I am sorry, but I do not understand what the actual issue is. The fact > > that come Coccinelle script complains is not enough to change the code. > > > > Right. There is no issue with the code, for usb_free_urb(NULL) is a no-op. > Proposing as a cleanup, without Fixes: tags, could be possible though. Yes, that would be acceptable. Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-20 6:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <f9303bdc-b1a7-be5e-56c6-dfa8232b8b55@web.de>
[not found] ` <521b63e1-9470-58ef-599e-50a1846e5380@web.de>
2023-03-20 4:21 ` [PATCH] Input: iforce - Fix exception handling in iforce_usb_probe() Dmitry Torokhov
2023-03-20 4:34 ` Tetsuo Handa
2023-03-20 6:05 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).