From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org,
Hillf Danton <hdanton@sina.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
cocci@inria.fr, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: iforce - Fix exception handling in iforce_usb_probe()
Date: Sun, 19 Mar 2023 21:21:16 -0700 [thread overview]
Message-ID: <ZBffPEIWcmYcaXR3@google.com> (raw)
In-Reply-To: <521b63e1-9470-58ef-599e-50a1846e5380@web.de>
On Sun, Mar 19, 2023 at 07:03:00PM +0100, Markus Elfring wrote:
> Date: Sun, 19 Mar 2023 18:50:51 +0100
>
> The label “fail” was used to jump to another pointer check despite of
> the detail in the implementation of the function “iforce_usb_probe”
> that it was determined already that a corresponding variable contained
> still a null pointer.
>
> 1. Use more appropriate labels instead.
>
> 2. Reorder jump targets at the end.
>
> 3. Delete a redundant check.
>
>
> This issue was detected by using the Coccinelle software.
I am sorry, but I do not understand what the actual issue is. The fact
that come Coccinelle script complains is not enough to change the code.
Thanks.
--
Dmitry
next parent reply other threads:[~2023-03-20 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f9303bdc-b1a7-be5e-56c6-dfa8232b8b55@web.de>
[not found] ` <521b63e1-9470-58ef-599e-50a1846e5380@web.de>
2023-03-20 4:21 ` Dmitry Torokhov [this message]
2023-03-20 4:34 ` [PATCH] Input: iforce - Fix exception handling in iforce_usb_probe() Tetsuo Handa
2023-03-20 6:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBffPEIWcmYcaXR3@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=cocci@inria.fr \
--cc=hdanton@sina.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).