From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Jeff LaBundy <jeff@labundy.com>,
Maxime Ripard <mripard@kernel.org>,
Max Krummenacher <max.krummenacher@toradex.com>,
Alistair Francis <alistair@alistair23.me>,
Jean Delvare <jdelvare@suse.de>, Job Noorman <job@noorman.info>,
Chris Morgan <macromorgan@hotmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>
Subject: Re: [PATCH] input: touchscreen: edt-ft5x06: select REGMAP_I2C
Date: Mon, 10 Apr 2023 16:55:59 -0700 [thread overview]
Message-ID: <ZDSiD3skPqT98KsO@google.com> (raw)
In-Reply-To: <ZDRBExF1xmxalMZc@makrotopia.org>
On Mon, Apr 10, 2023 at 06:02:11PM +0100, Daniel Golle wrote:
> After starting to use regmap API to access registers the edt-ft5x06
> driver depends on symbols provided by REGMAP_I2C:
>
> edt-ft5x06.o: in function `edt_ft5x06_ts_probe':
> edt-ft5x06.c:1154: undefined reference to `__regmap_init_i2c'
> edt-ft5x06.o: in function `edt_ft5x06_ts_identify':
> edt-ft5x06.c:897: undefined reference to `__regmap_init_i2c'
>
> Make sure support for I2C regmap is actually selected by adding this
> dependency to Kconfig.
>
> Fixes: 9dfd9708ffba ("Input: edt-ft5x06 - convert to use regmap API")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2023-04-10 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 17:02 [PATCH] input: touchscreen: edt-ft5x06: select REGMAP_I2C Daniel Golle
2023-04-10 23:55 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZDSiD3skPqT98KsO@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alistair@alistair23.me \
--cc=arnd@arndb.de \
--cc=daniel@makrotopia.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.de \
--cc=jeff@labundy.com \
--cc=job@noorman.info \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=max.krummenacher@toradex.com \
--cc=mripard@kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).