* [PATCH] input: touchscreen: edt-ft5x06: select REGMAP_I2C
@ 2023-04-10 17:02 Daniel Golle
2023-04-10 23:55 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Golle @ 2023-04-10 17:02 UTC (permalink / raw)
To: linux-input, linux-kernel, Dmitry Torokhov, Arnd Bergmann,
Robert Jarzmik, Jeff LaBundy, Maxime Ripard, Max Krummenacher,
Alistair Francis, Jean Delvare, Job Noorman, Chris Morgan,
Hans de Goede, Dario Binacchi
After starting to use regmap API to access registers the edt-ft5x06
driver depends on symbols provided by REGMAP_I2C:
edt-ft5x06.o: in function `edt_ft5x06_ts_probe':
edt-ft5x06.c:1154: undefined reference to `__regmap_init_i2c'
edt-ft5x06.o: in function `edt_ft5x06_ts_identify':
edt-ft5x06.c:897: undefined reference to `__regmap_init_i2c'
Make sure support for I2C regmap is actually selected by adding this
dependency to Kconfig.
Fixes: 9dfd9708ffba ("Input: edt-ft5x06 - convert to use regmap API")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/input/touchscreen/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 1feecd7ed3cb5..143ff43c67ae3 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -768,6 +768,7 @@ config TOUCHSCREEN_PENMOUNT
config TOUCHSCREEN_EDT_FT5X06
tristate "EDT FocalTech FT5x06 I2C Touchscreen support"
depends on I2C
+ select REGMAP_I2C
help
Say Y here if you have an EDT "Polytouch" touchscreen based
on the FocalTech FT5x06 family of controllers connected to
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: touchscreen: edt-ft5x06: select REGMAP_I2C
2023-04-10 17:02 [PATCH] input: touchscreen: edt-ft5x06: select REGMAP_I2C Daniel Golle
@ 2023-04-10 23:55 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2023-04-10 23:55 UTC (permalink / raw)
To: Daniel Golle
Cc: linux-input, linux-kernel, Arnd Bergmann, Robert Jarzmik,
Jeff LaBundy, Maxime Ripard, Max Krummenacher, Alistair Francis,
Jean Delvare, Job Noorman, Chris Morgan, Hans de Goede,
Dario Binacchi
On Mon, Apr 10, 2023 at 06:02:11PM +0100, Daniel Golle wrote:
> After starting to use regmap API to access registers the edt-ft5x06
> driver depends on symbols provided by REGMAP_I2C:
>
> edt-ft5x06.o: in function `edt_ft5x06_ts_probe':
> edt-ft5x06.c:1154: undefined reference to `__regmap_init_i2c'
> edt-ft5x06.o: in function `edt_ft5x06_ts_identify':
> edt-ft5x06.c:897: undefined reference to `__regmap_init_i2c'
>
> Make sure support for I2C regmap is actually selected by adding this
> dependency to Kconfig.
>
> Fixes: 9dfd9708ffba ("Input: edt-ft5x06 - convert to use regmap API")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-10 23:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-10 17:02 [PATCH] input: touchscreen: edt-ft5x06: select REGMAP_I2C Daniel Golle
2023-04-10 23:55 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).