* [PATCH V3] dt-bindings: input: pwm-beeper: convert to dt schema
@ 2023-04-07 7:52 Peng Fan (OSS)
2023-04-12 14:53 ` Rob Herring
2023-04-14 6:36 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Peng Fan (OSS) @ 2023-04-07 7:52 UTC (permalink / raw)
To: dmitry.torokhov, robh+dt, krzysztof.kozlowski+dt, s.hauer
Cc: linux-input, devicetree, linux-kernel, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Convert the binding doc to dt schema, and also fixed the
example from fixed-regulator to regulator-fixed.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
V3:
Drop description for pwms
Simplify description for amp-supply
update beeper-hz range to 10-10000
V2:
License update
Don't need to show providers
Make example complete
Decrease beeper hz
Misc update
.../devicetree/bindings/input/pwm-beeper.txt | 24 -----------
.../devicetree/bindings/input/pwm-beeper.yaml | 41 +++++++++++++++++++
2 files changed, 41 insertions(+), 24 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.txt
create mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.yaml
diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt
deleted file mode 100644
index 8fc0e48c20db..000000000000
--- a/Documentation/devicetree/bindings/input/pwm-beeper.txt
+++ /dev/null
@@ -1,24 +0,0 @@
-* PWM beeper device tree bindings
-
-Registers a PWM device as beeper.
-
-Required properties:
-- compatible: should be "pwm-beeper"
-- pwms: phandle to the physical PWM device
-
-Optional properties:
-- amp-supply: phandle to a regulator that acts as an amplifier for the beeper
-- beeper-hz: bell frequency in Hz
-
-Example:
-
-beeper_amp: amplifier {
- compatible = "fixed-regulator";
- gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
-};
-
-beeper {
- compatible = "pwm-beeper";
- pwms = <&pwm0>;
- amp-supply = <&beeper_amp>;
-};
diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
new file mode 100644
index 000000000000..a7611c206989
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/pwm-beeper.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: PWM beeper
+
+maintainers:
+ - Sascha Hauer <s.hauer@pengutronix.de>
+
+properties:
+ compatible:
+ const: pwm-beeper
+
+ pwms:
+ maxItems: 1
+
+ amp-supply:
+ description: an amplifier for the beeper
+
+ beeper-hz:
+ description: bell frequency in Hz
+ minimum: 10
+ maximum: 10000
+
+required:
+ - compatible
+ - pwms
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ beeper {
+ compatible = "pwm-beeper";
+ pwms = <&pwm0>;
+ amp-supply = <&beeper_amp>;
+ beeper-hz = <1000>;
+ };
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3] dt-bindings: input: pwm-beeper: convert to dt schema
2023-04-07 7:52 [PATCH V3] dt-bindings: input: pwm-beeper: convert to dt schema Peng Fan (OSS)
@ 2023-04-12 14:53 ` Rob Herring
2023-04-14 6:36 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-04-12 14:53 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: dmitry.torokhov, Peng Fan, linux-kernel, devicetree,
krzysztof.kozlowski+dt, robh+dt, s.hauer, linux-input
On Fri, 07 Apr 2023 15:52:59 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert the binding doc to dt schema, and also fixed the
> example from fixed-regulator to regulator-fixed.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V3:
> Drop description for pwms
> Simplify description for amp-supply
> update beeper-hz range to 10-10000
>
> V2:
> License update
> Don't need to show providers
> Make example complete
> Decrease beeper hz
> Misc update
>
>
> .../devicetree/bindings/input/pwm-beeper.txt | 24 -----------
> .../devicetree/bindings/input/pwm-beeper.yaml | 41 +++++++++++++++++++
> 2 files changed, 41 insertions(+), 24 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.txt
> create mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] dt-bindings: input: pwm-beeper: convert to dt schema
2023-04-07 7:52 [PATCH V3] dt-bindings: input: pwm-beeper: convert to dt schema Peng Fan (OSS)
2023-04-12 14:53 ` Rob Herring
@ 2023-04-14 6:36 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2023-04-14 6:36 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: robh+dt, krzysztof.kozlowski+dt, s.hauer, linux-input, devicetree,
linux-kernel, Peng Fan
On Fri, Apr 07, 2023 at 03:52:59PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Convert the binding doc to dt schema, and also fixed the
> example from fixed-regulator to regulator-fixed.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-14 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 7:52 [PATCH V3] dt-bindings: input: pwm-beeper: convert to dt schema Peng Fan (OSS)
2023-04-12 14:53 ` Rob Herring
2023-04-14 6:36 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).