linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff LaBundy <jeff@labundy.com>
To: "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: Javier Carrasco <javier.carrasco@wolfvision.net>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Stephen Boyd <sboyd@kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Uwe Kleine-g <u.kleine-koenig@pengutronix.de>,
	Bastian Hecht <hechtb@gmail.com>,
	Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [RFC v1 0/4] Input: support virtual objects on touchscreens
Date: Tue, 25 Apr 2023 11:02:53 -0500	[thread overview]
Message-ID: <ZEf5rfzs22HtQivB@nixie71> (raw)
In-Reply-To: <419c9d72-9791-46ff-8317-b4dfe2e2d0a3@t-8ch.de>

Hi Thomas,

On Tue, Apr 25, 2023 at 05:29:39PM +0200, Thomas Weißschuh wrote:
> Hi Javier,
> 
> On 2023-04-25 13:50:45+0200, Javier Carrasco wrote:
> > Some touchscreens are shipped with a physical layer on top of them where
> > a number of buttons and a resized touchscreen surface might be available.
> > 
> > In order to generate proper key events by overlay buttons and adjust the
> > touch events to a clipped surface, these patches offer a documented,
> > device-tree-based solution by means of helper functions.
> > An implementation for a specific touchscreen driver is also included.
> > 
> > The functions in ts-virtobj provide a simple workflow to acquire
> > physical objects from the device tree, map them into the device driver
> > structures as virtual objects and generate events according to
> > the object descriptions.
> > 
> > This solution has been tested with a JT240MHQS-E3 display, which uses
> > the st1624 as a touchscreen and provides two overly buttons and a frame
> > that clips its effective surface.
> 
> There are quite a few of notebooks from Asus that feature a printed
> numpad on their touchpad [0]. The mapping from the touch events to the
> numpad events needs to happen in software.

That example seems a kind of fringe use-case in my opinion; I think the
gap filled by this RFC is the case where a touchscreen has a printed
overlay with a key that represents a fixed function.

One problem I do see here is something like libinput or multitouch taking
hold of the input device, and swallowing the key presses because it sees
the device as a touchscreen and is not interested in these keys.

Therefore, my first impression is that the virtual keypad may be better
served by registering its own input device.

Great work by the way, Javier!

> 
> Do you think your solution is general enough to also support this
> usecase?
> 
> The differences I see are
> * not device-tree based
> * touchpads instead of touchscreens
> 
> > [..]
> 
> [0] https://unix.stackexchange.com/q/494400

Kind regards,
Jeff LaBundy

  reply	other threads:[~2023-04-25 16:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 11:50 [RFC v1 0/4] Input: support virtual objects on touchscreens Javier Carrasco
2023-04-25 11:50 ` [RFC v1 1/4] Input: ts-virtobj - Add touchsreen virtual object handling to the core Javier Carrasco
2023-04-25 11:50 ` [RFC v1 2/4] dt-bindings: touchscreen: add virtual-touchscreen and virtual-buttons properties Javier Carrasco
2023-04-25 11:50 ` [RFC v1 3/4] Input: st1232 - add virtual touchscreen and buttons handling Javier Carrasco
2023-04-25 11:50 ` [RFC v1 4/4] dt-bindings: input: touchscreen: st1232: add virtual objects to the example Javier Carrasco
2023-04-25 15:29 ` [RFC v1 0/4] Input: support virtual objects on touchscreens Thomas Weißschuh
2023-04-25 16:02   ` Jeff LaBundy [this message]
2023-04-27 15:59     ` Javier Carrasco
2023-04-27 17:23       ` Jeff LaBundy
2023-04-28  6:08         ` Javier Carrasco
2023-05-04  4:29         ` Peter Hutterer
2023-05-06 18:35           ` Jeff LaBundy
2023-04-27 11:04 ` Pavel Machek
2023-04-27 11:11   ` Michael Riesch
2023-04-27 13:15     ` Pavel Machek
2023-04-27 17:45       ` Jeff LaBundy
2023-05-01 12:32 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZEf5rfzs22HtQivB@nixie71 \
    --to=jeff@labundy.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hechtb@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=javier.carrasco@wolfvision.net \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=robh+dt@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=sboyd@kernel.org \
    --cc=sre@kernel.org \
    --cc=thomas@t-8ch.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).