From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Siarhei Vishniakou <svv@google.com>
Cc: Biswarup Pal <biswarupp@google.com>,
kernel-team@android.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Call input_set_timestamp for events injected using uinput
Date: Fri, 28 Apr 2023 12:52:43 -0700 [thread overview]
Message-ID: <ZEwkC7BiUpq7kbjc@google.com> (raw)
In-Reply-To: <CAKF84v2Rw8xQv=m+ciL+n_uXhyAZWFmhYpgA63Q=DnVh5sbOsw@mail.gmail.com>
Hi,
On Fri, Apr 28, 2023 at 11:38:36AM -0700, Siarhei Vishniakou wrote:
> Thanks Biswarup!
Please avoid top posting.
>
> Just to add a bit of context: we were concerned with breaking the
> existing uinput usages where the caller might be setting an incorrect
> value (since previously, that had no effect).
> So the 10 second guard was added to fall back to the default behaviour
> for those devices.
What is the benefit of sending this in uinput? It is not much close
to the exact time the hardware generated the event than the timestamp
generated in the input core, so I do not see why it is needed in uinput.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-04-28 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 0:01 [PATCH] Call input_set_timestamp for events injected using uinput Biswarup Pal
2023-04-28 18:38 ` Siarhei Vishniakou
2023-04-28 19:52 ` Dmitry Torokhov [this message]
2023-04-28 19:54 ` Dmitry Torokhov
2023-05-02 1:05 ` Dmitry Torokhov
2023-05-02 2:13 ` Peter Hutterer
2023-05-02 3:21 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEwkC7BiUpq7kbjc@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=biswarupp@google.com \
--cc=kernel-team@android.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svv@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).