From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Markus Schneider-Pargmann <msp@baylibre.com>,
linux-input@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] Input: tps65219-pwrbutton - Use regmap_set_bits()
Date: Tue, 6 Jun 2023 12:12:54 -0700 [thread overview]
Message-ID: <ZH+FNhNc0Fpi/U2j@google.com> (raw)
In-Reply-To: <20230605161458.117361-2-u.kleine-koenig@pengutronix.de>
On Mon, Jun 05, 2023 at 06:14:58PM +0200, Uwe Kleine-König wrote:
> regmap_set_bits() is equivalent to regmap_update_bits() if mask == val.
> The probe function uses regmap_clear_bits() to enable irqs, so
> symmetrically make use of regmap_set_bits() to disable them. There is no
> semantic difference.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2023-06-06 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 16:14 [PATCH 1/2] Input: tps65219-pwrbutton - Convert to .remove_new() Uwe Kleine-König
2023-06-05 16:14 ` [PATCH 2/2] Input: tps65219-pwrbutton - Use regmap_set_bits() Uwe Kleine-König
2023-06-06 9:20 ` Markus Schneider-Pargmann
2023-06-06 19:12 ` Dmitry Torokhov [this message]
2023-06-06 9:19 ` [PATCH 1/2] Input: tps65219-pwrbutton - Convert to .remove_new() Markus Schneider-Pargmann
2023-06-06 19:12 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH+FNhNc0Fpi/U2j@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).