* [PATCH] Input: rotary_encoder - don't double assign input->dev.parent
@ 2023-06-07 9:10 Roi L
2023-07-12 21:11 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Roi L @ 2023-06-07 9:10 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, Roi L
devm_input_allocate_device() already assigns the @dev.parent field of the
input device/structure, so there's no need to reassign input->dev.parent
to dev.
Signed-off-by: Roi L <roeilev321_@outlook.com>
---
drivers/input/misc/rotary_encoder.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
index 22ec62083065..5c11cbe30167 100644
--- a/drivers/input/misc/rotary_encoder.c
+++ b/drivers/input/misc/rotary_encoder.c
@@ -255,7 +255,6 @@ static int rotary_encoder_probe(struct platform_device *pdev)
input->name = pdev->name;
input->id.bustype = BUS_HOST;
- input->dev.parent = dev;
if (encoder->relative_axis)
input_set_capability(input, EV_REL, encoder->axis);
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: rotary_encoder - don't double assign input->dev.parent
2023-06-07 9:10 [PATCH] Input: rotary_encoder - don't double assign input->dev.parent Roi L
@ 2023-07-12 21:11 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2023-07-12 21:11 UTC (permalink / raw)
To: Roi L; +Cc: linux-input
On Wed, Jun 07, 2023 at 12:10:40PM +0300, Roi L wrote:
> devm_input_allocate_device() already assigns the @dev.parent field of the
> input device/structure, so there's no need to reassign input->dev.parent
> to dev.
>
> Signed-off-by: Roi L <roeilev321_@outlook.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-12 21:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-07 9:10 [PATCH] Input: rotary_encoder - don't double assign input->dev.parent Roi L
2023-07-12 21:11 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).