From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F005EB64DA for ; Wed, 12 Jul 2023 21:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232541AbjGLVLj (ORCPT ); Wed, 12 Jul 2023 17:11:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232557AbjGLVLi (ORCPT ); Wed, 12 Jul 2023 17:11:38 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F5A71FCD for ; Wed, 12 Jul 2023 14:11:29 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-6686c74183cso33397b3a.1 for ; Wed, 12 Jul 2023 14:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689196288; x=1691788288; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5mEISEtXVLCnOqtjDWmoSzJcHSEwCtQ7AljaMITB2Ek=; b=SJPS2We8PmC5g3ecCYJWv0lsuJOhRRlY3MQOASyWDo3ZHWRxh0Hhf5w2XLOyfLmOiQ QyIixbG4dpqaNq3B1qRJI39i5kH0ohMCI/SlxSDiDjBVqvSB/O70pLwqeZ0Ck16D1nEL 2/7MczQNJYcAU7U9j8t78axZQmsQjaKcxp657/+zzuqKjiH1SIPATceRr+p98UapJQqj xP6M9C4EUCg5/Xcg8BZZC0VhjD+2Bndyv6p+DcscYUOPE/d1Xz3wjTRQ4CziEaFA838d BHINi4XQSsyguKvFALr8wAZKu9ymGjcuwtFHsDYNmVWIkoJlzxlz12lafFEdv9U9kPuB yUVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689196288; x=1691788288; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5mEISEtXVLCnOqtjDWmoSzJcHSEwCtQ7AljaMITB2Ek=; b=Bf7MGKGMUvv+T+1eZ5rjjq3OoFsz/KHNPwcfR8BQ57+yAqMNsb1zvPdMuZTkg+LZmc Xb2JHJUr3EdBdUhpbxWqE2BdCMJ98q0HlYSfpOZa1+IufBcj9r/m+WhOkwR+Ai7GoRxg fSzAoafAnBbywVUfnyNNiUvD98Kb7zP8tg0XdzgbCkI9Tljjn8VLNUezGh8pKG9cMlpd GJ3EChCHAD4Tx13iXpg4XC7a/h08j10SHUuUFUvRZELry3B6+RGdqjNzUZ+9qjGQODWi Gv1DJ+jZLVpIdRGGeF7TgS+zZIxhctDnA1H0+ET+OcXY7gE2fJfV2KbLbO5T13s6S3DF VLoA== X-Gm-Message-State: ABy/qLbkf4fxGAMiB3IahBAby5shmwO17fKms+rnrudCMWEKUd+5atam 09nFdf98ncMNWnctS01Guvc= X-Google-Smtp-Source: APBJJlEykMxvp6PI0/SYYBKbGAU/tFDtjhh9bajsEu5Nm1KmdhuXwP6EkZNos1xkd/PkI1OxeMONBQ== X-Received: by 2002:a05:6a20:8c07:b0:12e:5017:ad3a with SMTP id j7-20020a056a208c0700b0012e5017ad3amr18318968pzh.23.1689196288501; Wed, 12 Jul 2023 14:11:28 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:a606:1b1e:7f66:3ee0]) by smtp.gmail.com with ESMTPSA id j9-20020a62b609000000b00678afd4824asm4108768pff.175.2023.07.12.14.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 14:11:28 -0700 (PDT) Date: Wed, 12 Jul 2023 14:11:25 -0700 From: Dmitry Torokhov To: Roi L Cc: linux-input@vger.kernel.org Subject: Re: [PATCH] Input: rotary_encoder - don't double assign input->dev.parent Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, Jun 07, 2023 at 12:10:40PM +0300, Roi L wrote: > devm_input_allocate_device() already assigns the @dev.parent field of the > input device/structure, so there's no need to reassign input->dev.parent > to dev. > > Signed-off-by: Roi L Applied, thank you. -- Dmitry