From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/1] Input: gameport: add ISA and HAS_IOPORT dependencies
Date: Wed, 5 Jul 2023 17:34:32 -0700 [thread overview]
Message-ID: <ZKYMGMKuYC0/wOLN@google.com> (raw)
In-Reply-To: <20230703152355.3897456-2-schnelle@linux.ibm.com>
Hi Niklas,
On Mon, Jul 03, 2023 at 05:23:55PM +0200, Niklas Schnelle wrote:
> +static void gameport_setup_default_handlers(struct gameport *gameport)
> +{
> + if (gameport->trigger && gameport->read)
> + return;
> +
> + if (!IS_ENABLED(CONFIG_HAS_IOPORT))
> + dev_err(&gameport->dev,
> + "I/O port access is required for %s (%s) but is not available\n",
> + gameport->phys, gameport->name);
I combined these 2 conditions into one and applied, thank you.
--
Dmitry
prev parent reply other threads:[~2023-07-06 0:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:23 [PATCH v6 0/1] Input: gameport: Handle HAS_IOPORT dependencies Niklas Schnelle
2023-07-03 15:23 ` [PATCH v6 1/1] Input: gameport: add ISA and " Niklas Schnelle
2023-07-06 0:34 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKYMGMKuYC0/wOLN@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).