* [PATCH v2 1/2] dt-bindings: Input: exc3000 - Support power supply regulators
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.067a6add-28c9-4499-a235-882581bddc85@emailsignatures365.codetwo.com>
@ 2023-07-07 13:10 ` Mike Looijmans
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.e9863e93-aebd-4f13-b014-08dab638277d@emailsignatures365.codetwo.com>
2023-07-08 0:00 ` [PATCH v2 1/2] dt-bindings: " Dmitry Torokhov
0 siblings, 2 replies; 4+ messages in thread
From: Mike Looijmans @ 2023-07-07 13:10 UTC (permalink / raw)
To: devicetree, linux-input
Cc: Mike Looijmans, Conor Dooley, Dmitry Torokhov,
Krzysztof Kozlowski, Rob Herring, linux-kernel
Add power supply regulator support to the exc3000 devices.
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
(no changes since v1)
.../devicetree/bindings/input/touchscreen/eeti,exc3000.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
index 007adbc89c14..9dc25d30a0a8 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/eeti,exc3000.yaml
@@ -24,6 +24,8 @@ properties:
maxItems: 1
reset-gpios:
maxItems: 1
+ vdd-supply:
+ description: Power supply regulator for the chip
touchscreen-size-x: true
touchscreen-size-y: true
touchscreen-inverted-x: true
--
2.17.1
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands
T: +31 (0) 499 33 69 69
E: mike.looijmans@topicproducts.com
W: www.topic.nl
Please consider the environment before printing this e-mail
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] Input: exc3000 - Support power supply regulators
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.e9863e93-aebd-4f13-b014-08dab638277d@emailsignatures365.codetwo.com>
@ 2023-07-07 13:10 ` Mike Looijmans
2023-07-08 0:00 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Mike Looijmans @ 2023-07-07 13:10 UTC (permalink / raw)
To: devicetree, linux-input
Cc: Mike Looijmans, Dmitry Torokhov, Uwe Kleine-König,
linux-kernel
Add power supply regulator support to the exc3000 devices.
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
Changes in v2:
Add missing "return" statement
Use devm_regulator_get_enable without _optional
drivers/input/touchscreen/exc3000.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/input/touchscreen/exc3000.c b/drivers/input/touchscreen/exc3000.c
index 4af4c1e5d0da..e3f6d21b3c1b 100644
--- a/drivers/input/touchscreen/exc3000.c
+++ b/drivers/input/touchscreen/exc3000.c
@@ -18,6 +18,7 @@
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/regulator/consumer.h>
#include <linux/sizes.h>
#include <linux/timer.h>
#include <asm/unaligned.h>
@@ -360,6 +361,12 @@ static int exc3000_probe(struct i2c_client *client)
if (IS_ERR(data->reset))
return PTR_ERR(data->reset);
+ /* For proper reset sequence, enable power while reset asserted */
+ error = devm_regulator_get_enable(&client->dev, "vdd");
+ if (error && error != -ENODEV)
+ return dev_err_probe(&client->dev, error,
+ "failed to request vdd regulator\n");
+
if (data->reset) {
msleep(EXC3000_RESET_MS);
gpiod_set_value_cansleep(data->reset, 0);
--
2.17.1
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Products B.V.
Materiaalweg 4, 5681 RJ Best
The Netherlands
T: +31 (0) 499 33 69 69
E: mike.looijmans@topicproducts.com
W: www.topic.nl
Please consider the environment before printing this e-mail
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: Input: exc3000 - Support power supply regulators
2023-07-07 13:10 ` [PATCH v2 1/2] dt-bindings: Input: exc3000 - Support power supply regulators Mike Looijmans
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.e9863e93-aebd-4f13-b014-08dab638277d@emailsignatures365.codetwo.com>
@ 2023-07-08 0:00 ` Dmitry Torokhov
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2023-07-08 0:00 UTC (permalink / raw)
To: Mike Looijmans
Cc: devicetree, linux-input, Conor Dooley, Krzysztof Kozlowski,
Rob Herring, linux-kernel
On Fri, Jul 07, 2023 at 03:10:41PM +0200, Mike Looijmans wrote:
> Add power supply regulator support to the exc3000 devices.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] Input: exc3000 - Support power supply regulators
2023-07-07 13:10 ` [PATCH v2 2/2] " Mike Looijmans
@ 2023-07-08 0:00 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2023-07-08 0:00 UTC (permalink / raw)
To: Mike Looijmans
Cc: devicetree, linux-input, Uwe Kleine-König, linux-kernel
On Fri, Jul 07, 2023 at 03:10:42PM +0200, Mike Looijmans wrote:
> Add power supply regulator support to the exc3000 devices.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-08 0:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.067a6add-28c9-4499-a235-882581bddc85@emailsignatures365.codetwo.com>
2023-07-07 13:10 ` [PATCH v2 1/2] dt-bindings: Input: exc3000 - Support power supply regulators Mike Looijmans
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.e9863e93-aebd-4f13-b014-08dab638277d@emailsignatures365.codetwo.com>
2023-07-07 13:10 ` [PATCH v2 2/2] " Mike Looijmans
2023-07-08 0:00 ` Dmitry Torokhov
2023-07-08 0:00 ` [PATCH v2 1/2] dt-bindings: " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).