From: Thierry Reding <thierry.reding@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-input@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: tegra-kbc - use devm_platform_ioremap_resource
Date: Mon, 10 Jul 2023 15:11:23 +0200 [thread overview]
Message-ID: <ZKwDe77yPmaaNoiE@orome> (raw)
In-Reply-To: <20230709134109.182418-1-martin@kaiser.cx>
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
On Sun, Jul 09, 2023 at 03:41:08PM +0200, Martin Kaiser wrote:
> devm_platform_get_and_ioremap_resource maps a resource and returns its
> physical address. If we don't need the physical address, we should call
> devm_platform_ioremap_resource instead.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/input/keyboard/tegra-kbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Different variations of these have been going around for a while now. I
don't really see much use in these tiny conversions.
But the patch also isn't wrong, so while I'm at it:
Acked-by: Thierry Reding <treding@nvidia.com>
>
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index d5a6c7d8eb25..c9a823ea45d0 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -640,7 +640,7 @@ static int tegra_kbc_probe(struct platform_device *pdev)
>
> timer_setup(&kbc->timer, tegra_kbc_keypress_timer, 0);
>
> - kbc->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> + kbc->mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(kbc->mmio))
> return PTR_ERR(kbc->mmio);
>
> --
> 2.30.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-07-10 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 13:41 [PATCH] Input: tegra-kbc - use devm_platform_ioremap_resource Martin Kaiser
2023-07-10 13:11 ` Thierry Reding [this message]
2023-07-10 19:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKwDe77yPmaaNoiE@orome \
--to=thierry.reding@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).