Re: [PATCH] Input: xpad - add support for HyperX Game Controllers

Re: [PATCH] Input: xpad - add support for HyperX Game Controllers

[Dmitry Torokhov]

Hi Max,

On Sat, Jul 08, 2023 at 01:30:16AM +0000, Nguyen, Max wrote:
> Add HyperX controller support to xpad_device and xpad_table.

Unfortunately the patch is whitespace-damaged, could you please
resubmit?

> 
> Reported-by: Chris Toledanes <chris.toledanes@hp.com>
> Acked-by: Carl Ng <carl.ng@hp.com>
> Acked-by: Jessie Jin <yan.jin1@hp.com>

Acks should be given at least in public and they are typically reserved
for maintainers or people actively working on the code/driver in
question. See Documentation/process/5.Posting.rst

> Signed-off-by: Maxwell Nguyen <maxwell.nguyen@hp.com>

> ---
> 
> drivers/input/joystick/xpad.c | 3 ++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index cdb193317c3b..a5e507b8f619 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -130,6 +130,7 @@ static const struct xpad_device {
>                  { 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 },
>                  { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 },
>                  { 0x03eb, 0xff02, "Wooting Two (Legacy)", 0, XTYPE_XBOX360 },
> +                { 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE },
>                  { 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX },
>                  { 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX },
>                  { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX },
> @@ -457,6 +458,8 @@ static const struct usb_device_id xpad_table[] = {
>                  { USB_INTERFACE_INFO('X', 'B', 0) },          /* Xbox USB-IF not-approved class */
>                  XPAD_XBOX360_VENDOR(0x0079),                             /* GPD Win 2 controller */
>                  XPAD_XBOX360_VENDOR(0x03eb),                             /* Wooting Keyboards (Legacy) */
> +                XPAD_XBOX360_VENDOR(0x03f0),                              /* HyperX Xbox 360 controllers */
> +                XPAD_XBOXONE_VENDOR(0x03f0),                            /* HyperX Xbox One controllers */
>                  XPAD_XBOX360_VENDOR(0x044f),                              /* Thrustmaster Xbox 360 controllers */
>                  XPAD_XBOX360_VENDOR(0x045e),                             /* Microsoft Xbox 360 controllers */
>                  XPAD_XBOXONE_VENDOR(0x045e),                            /* Microsoft Xbox One controllers */
> 

Thanks.

-- 
Dmitry

RE: [PATCH] Input: xpad - add support for HyperX Game Controllers

[Nguyen, Max]

Hi Dmitry,

I have sent over a new patch.  Let me know the whitespace-damage issue is resolved.  I will need to adjust the acks since I had missed it.

Regards,
Max

-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Sent: Monday, July 10, 2023 11:59 AM
To: Nguyen, Max <maxwell.nguyen@hp.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: xpad - add support for HyperX Game Controllers

CAUTION: External Email

Hi Max,

On Sat, Jul 08, 2023 at 01:30:16AM +0000, Nguyen, Max wrote:
> Add HyperX controller support to xpad_device and xpad_table.

Unfortunately the patch is whitespace-damaged, could you please resubmit?

>
> Reported-by: Chris Toledanes <chris.toledanes@hp.com>
> Acked-by: Carl Ng <carl.ng@hp.com>
> Acked-by: Jessie Jin <yan.jin1@hp.com>

Acks should be given at least in public and they are typically reserved for maintainers or people actively working on the code/driver in question. See Documentation/process/5.Posting.rst

> Signed-off-by: Maxwell Nguyen <maxwell.nguyen@hp.com>

> ---
>
> drivers/input/joystick/xpad.c | 3 ++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/input/joystick/xpad.c 
> b/drivers/input/joystick/xpad.c index cdb193317c3b..a5e507b8f619 
> 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -130,6 +130,7 @@ static const struct xpad_device {
>                  { 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 },
>                  { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 },
>                  { 0x03eb, 0xff02, "Wooting Two (Legacy)", 0, 
> XTYPE_XBOX360 },
> +                { 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, 
> + XTYPE_XBOXONE },
>                  { 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX },
>                  { 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX },
>                  { 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, 
> XTYPE_XBOX }, @@ -457,6 +458,8 @@ static const struct usb_device_id xpad_table[] = {
>                  { USB_INTERFACE_INFO('X', 'B', 0) },          /* Xbox USB-IF not-approved class */
>                  XPAD_XBOX360_VENDOR(0x0079),                             /* GPD Win 2 controller */
>                  XPAD_XBOX360_VENDOR(0x03eb),                             /* Wooting Keyboards (Legacy) */
> +                XPAD_XBOX360_VENDOR(0x03f0),                              /* HyperX Xbox 360 controllers */
> +                XPAD_XBOXONE_VENDOR(0x03f0),                            /* HyperX Xbox One controllers */
>                  XPAD_XBOX360_VENDOR(0x044f),                              /* Thrustmaster Xbox 360 controllers */
>                  XPAD_XBOX360_VENDOR(0x045e),                             /* Microsoft Xbox 360 controllers */
>                  XPAD_XBOXONE_VENDOR(0x045e),                            /* Microsoft Xbox One controllers */
>

Thanks.

--
Dmitry

Re: [PATCH] Input: xpad - add support for HyperX Game Controllers

[Dmitry Torokhov]

Hi Max,

On Thu, Jul 13, 2023 at 12:43:19AM +0000, Nguyen, Max wrote:
> Hi Dmitry,
> 
> I have sent over a new patch.  Let me know the whitespace-damage issue is resolved.  I will need to adjust the acks since I had missed it.
> 

It looks like you are using Outlook, and it will not work. It sends a
mix of HTML and plain text, and it mangles the plain text.

You need to look into setting up "git send-email" or mutt or something
else besides Outlook to send kernel patches.

Thanks.

-- 
Dmitry

RE: [PATCH] Input: xpad - add support for HyperX Game Controllers

[Nguyen, Max]

Hi Dmitry,

There is an option on outlook to change outbound mails to plain text instead of HTML.  Would this work?

Regards,
Max

-----Original Message-----
From: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
Sent: Thursday, July 13, 2023 10:38 AM
To: Nguyen, Max <maxwell.nguyen@hp.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: xpad - add support for HyperX Game Controllers

CAUTION: External Email

Hi Max,

On Thu, Jul 13, 2023 at 12:43:19AM +0000, Nguyen, Max wrote:
> Hi Dmitry,
>
> I have sent over a new patch.  Let me know the whitespace-damage issue is resolved.  I will need to adjust the acks since I had missed it.
>

It looks like you are using Outlook, and it will not work. It sends a mix of HTML and plain text, and it mangles the plain text.

You need to look into setting up "git send-email" or mutt or something else besides Outlook to send kernel patches.

Thanks.

--
Dmitry

Re: [PATCH] Input: xpad - add support for HyperX Game Controllers

[Dmitry Torokhov]

On Thu, Jul 13, 2023 at 09:18:37PM +0000, Nguyen, Max wrote:
> Hi Dmitry,
> 
> There is an option on outlook to change outbound mails to plain text instead of HTML.  Would this work?

Sorry but I do not know if that is enough. I have not used Outlook for
more than 15 years.

> 
> Regards,
> Max
> 
> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com> 
> Sent: Thursday, July 13, 2023 10:38 AM
> To: Nguyen, Max <maxwell.nguyen@hp.com>
> Cc: linux-input@vger.kernel.org
> Subject: Re: [PATCH] Input: xpad - add support for HyperX Game Controllers
> 
> CAUTION: External Email
> 
> Hi Max,
> 
> On Thu, Jul 13, 2023 at 12:43:19AM +0000, Nguyen, Max wrote:
> > Hi Dmitry,
> >
> > I have sent over a new patch.  Let me know the whitespace-damage issue is resolved.  I will need to adjust the acks since I had missed it.
> >
> 
> It looks like you are using Outlook, and it will not work. It sends a mix of HTML and plain text, and it mangles the plain text.
> 
> You need to look into setting up "git send-email" or mutt or something else besides Outlook to send kernel patches.
> 
> Thanks.
> 
> --
> Dmitry
> 

-- 
Dmitry