From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
Kevin Wells <wellsk40@gmail.com>,
Durgesh Pattamatta <durgesh.pattamatta@nxp.com>,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] Input: lpc32xx_ts - stop_tsc when driver remove
Date: Mon, 10 Jul 2023 17:40:46 -0700 [thread overview]
Message-ID: <ZKylDj4ONoD9cAUm@google.com> (raw)
In-Reply-To: <20230705052346.39337-9-frank.li@vivo.com>
Hi,
On Wed, Jul 05, 2023 at 01:23:45PM +0800, Yangtao Li wrote:
> When the driver is removed, we need to close the device.
>
> Fixes: 3045a5f5202a ("Input: add LPC32xx touchscreen controller driver")
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> drivers/input/touchscreen/lpc32xx_ts.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/touchscreen/lpc32xx_ts.c b/drivers/input/touchscreen/lpc32xx_ts.c
> index 15b5cb763526..ffdd748a9992 100644
> --- a/drivers/input/touchscreen/lpc32xx_ts.c
> +++ b/drivers/input/touchscreen/lpc32xx_ts.c
> @@ -305,6 +305,8 @@ static int lpc32xx_ts_remove(struct platform_device *pdev)
> struct lpc32xx_tsc *tsc = platform_get_drvdata(pdev);
> struct resource *res;
>
> + lpc32xx_stop_tsc(tsc);
> +
This change is not needed because lpc32xx_stop_tsc() is already being
called from lpc32xx_ts_close() which is called when we unregister input
device (provided that open() was called earlier).
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-07-11 0:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 5:23 [PATCH 01/10] Input: bcm-keypad - Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-05 5:23 ` [PATCH 02/10] Input: lpc32xx-keys " Yangtao Li
2023-07-05 5:23 ` [PATCH 03/10] Input: nspire-keypad - Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-05 5:23 ` [PATCH 04/10] Input: omap4-keyad - Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-05 5:23 ` [PATCH 05/10] Input: opencores-kbd " Yangtao Li
2023-07-05 5:23 ` [PATCH 06/10] Input: pxa27x_keypad " Yangtao Li
2023-07-05 5:23 ` [PATCH 07/10] Input: sun4i-lradc-keys " Yangtao Li
2023-07-11 18:27 ` Jernej Škrabec
2023-07-05 5:23 ` [PATCH 08/10] Input: nomadik-ske-keypad - Convert to use devm_* api Yangtao Li
2023-07-11 0:42 ` Dmitry Torokhov
2023-07-05 5:23 ` [PATCH 09/10] Input: lpc32xx_ts - stop_tsc when driver remove Yangtao Li
2023-07-11 0:40 ` Dmitry Torokhov [this message]
2023-07-05 5:23 ` [PATCH 10/10] Input: lpc32xx_ts - Convert to use devm_* api Yangtao Li
2023-07-11 0:43 ` [PATCH 01/10] Input: bcm-keypad - Convert to devm_platform_ioremap_resource() Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKylDj4ONoD9cAUm@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=durgesh.pattamatta@nxp.com \
--cc=frank.li@vivo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vz@mleia.com \
--cc=wellsk40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).