From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-input@vger.kernel.org, Yangtao Li <frank.li@vivo.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: lm8323 - convert to use devm_* api
Date: Mon, 24 Jul 2023 12:01:22 -0700 [thread overview]
Message-ID: <ZL7KghF8L+y1Fzcs@google.com> (raw)
In-Reply-To: <b83df292-6f7a-a8bf-895e-6df80a17029f@wanadoo.fr>
On Mon, Jul 24, 2023 at 08:53:11PM +0200, Christophe JAILLET wrote:
> Le 24/07/2023 à 07:29, Dmitry Torokhov a écrit :
> > From: Yangtao Li <frank.li@vivo.com>
> > +
> > + err = devm_led_classdev_register(dev, &pwm->cdev);
^^^^^^^^^^^^^^
...
> > -
> > - for (i = 0; i < 3; i++)
> > - if (lm->pwm[i].enabled)
> > - led_classdev_unregister(&lm->pwm[i].cdev);
>
> this look wrong.
Why? It will be cleared up by devm.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-07-24 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 5:28 [PATCH 1/2] Input: lm8323 - rely on device core to create kp_disable attribute Dmitry Torokhov
2023-07-24 5:29 ` [PATCH 2/2] Input: lm8323 - convert to use devm_* api Dmitry Torokhov
2023-07-24 18:53 ` Christophe JAILLET
2023-07-24 19:01 ` Dmitry Torokhov [this message]
2023-07-24 19:26 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZL7KghF8L+y1Fzcs@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=frank.li@vivo.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).