From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "Mike Looijmans" <mike.looijmans@topic.nl>,
"Andreas Helbech Kleist" <andreaskleist@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-input@vger.kernel.org,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Input: exc3000 - Simplify probe()
Date: Mon, 17 Jul 2023 08:58:24 -0700 [thread overview]
Message-ID: <ZLVlIPHdmEGdG5D1@google.com> (raw)
In-Reply-To: <20230717131756.240645-2-biju.das.jz@bp.renesas.com>
Hi Biju,
On Mon, Jul 17, 2023 at 02:17:55PM +0100, Biju Das wrote:
> The exc3000_id.driver_data could store a pointer to the info,
> like for ACPI/DT-based matching, making I2C, ACPI and DT-based
> matching more similar.
>
> After that, we can simplify the probe() by replacing device_get_
> match_data() and i2c_match_id() by i2c_get_match_data() as we have
> similar I2C, ACPI and DT-based matching table.
Have you considered enhancing device_get_match_data() to allow for
bus-specific "get_match_data" implementations? This way the drivers
would simply call device_get_match_data() and not care if they are I2C,
SPI, or something else...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-07-17 15:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 13:17 [PATCH v2 0/2] exc3000 driver enhancements Biju Das
2023-07-17 13:17 ` [PATCH v2 1/2] Input: exc3000 - Simplify probe() Biju Das
2023-07-17 15:58 ` Dmitry Torokhov [this message]
2023-07-17 16:35 ` Biju Das
2023-07-17 18:15 ` Mark Brown
2023-07-17 18:27 ` Biju Das
2023-07-17 18:28 ` Dmitry Torokhov
2023-07-17 18:45 ` Biju Das
2023-07-18 18:36 ` Dmitry Torokhov
2023-07-19 6:43 ` Biju Das
2023-07-21 22:10 ` Dmitry Torokhov
2023-07-22 17:51 ` Biju Das
2023-07-23 1:17 ` Dmitry Torokhov
2023-07-23 6:05 ` Biju Das
2023-07-23 6:50 ` Biju Das
2023-07-23 20:06 ` Dmitry Torokhov
2023-07-17 18:49 ` Mark Brown
2023-07-17 13:17 ` [PATCH v2 2/2] Input: exc3000 - Drop enum eeti_dev_id and split exc3000_info[] Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLVlIPHdmEGdG5D1@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andreaskleist@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-input@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).