From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89769EE4996 for ; Mon, 21 Aug 2023 10:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234725AbjHUKcs (ORCPT ); Mon, 21 Aug 2023 06:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234727AbjHUKcq (ORCPT ); Mon, 21 Aug 2023 06:32:46 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5334E7; Mon, 21 Aug 2023 03:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692613964; x=1724149964; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=1fn7q7fMoBV0BbqGytVXn+QfD/C+CWrW/pDiqREweWk=; b=T8R0Qh3K0+ss/ltSnEdBInvS1KoKVWIG7NObbq0HymNCALC9uf+/Gxv2 D91FCjQ3xcxBSvkah4+II+r9+4MpXlnx+ObzAJK14bNQWpXM3W+MwJDjd iddBIACMLSOp+/ApeXF+hJtIN/t0KRkzSh0Cc+oFi3bIjq8EsxfZXRKJ5 AW1oSkp9EKl4o4Jf7H2nQ33YgzgN3yYaVMMu0ksJIdfchgu9rk4QqQUMa uknhd3lrKXq3N2nmmTjxzyVK0CPxmq8TR/m+75GRIm2cJqLn5ujidxEog WN2IgHR61q6BAGPEY/DbAZgarHexeFHuMitwtlSpiBmS1VbHzhzzKn9WJ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10808"; a="437476081" X-IronPort-AV: E=Sophos;i="6.01,189,1684825200"; d="scan'208";a="437476081" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 03:32:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10808"; a="765319278" X-IronPort-AV: E=Sophos;i="6.01,189,1684825200"; d="scan'208";a="765319278" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga008.jf.intel.com with ESMTP; 21 Aug 2023 03:32:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qY2DB-009sOm-0m; Mon, 21 Aug 2023 13:32:41 +0300 Date: Mon, 21 Aug 2023 13:32:40 +0300 From: Andy Shevchenko To: Benjamin Tissoires Cc: Benjamin Tissoires , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 00/12] HID: cp2112: Cleanups and refactorings Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Mon, Aug 21, 2023 at 12:19:39PM +0200, Benjamin Tissoires wrote: > On Mon, Aug 21, 2023 at 11:35 AM Andy Shevchenko > wrote: > > On Mon, Aug 21, 2023 at 12:34:30PM +0300, Andy Shevchenko wrote: > > > On Mon, Aug 21, 2023 at 10:51:04AM +0200, Benjamin Tissoires wrote: > > > > On Aug 21 2023, Andy Shevchenko wrote: ... > > > > Long story short, I'm not able to test it right now (and I got quite > > > > some backlog as you can imagine). IIRC the code was fine, so I think we > > > > can just take the series as is, and work on the quirks (if any) later. > > > > > > Thank you! > > > > > > The thing that might be broken is interrupts handling. If that works, > > > I'm pretty confident with the rest. > > > > I.o.w. first 5 patches to test is already 98% of guarantee that everything > > is fine. > > Actually I applied you series locally, and applied Danny's patches on > top, and I could run your series in qemu with the cp2112 as USB > passthrough. > > Everything is working fine, so I can take this one just now. Thank you! I assume you have some IRQ (like GPIO button) to test with that. If no, it's easily to describe (in ACPI, see [1]) and use a wire to emulate the button presses. In that case the /proc/interrupts should show the different numbers. [1]: https://github.com/westeri/meta-acpi/blob/master/recipes-bsp/acpi-tables/samples/edison/buttons.asli -- With Best Regards, Andy Shevchenko