From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF61DEE49A4 for ; Tue, 22 Aug 2023 15:50:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237357AbjHVPuU (ORCPT ); Tue, 22 Aug 2023 11:50:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237356AbjHVPuS (ORCPT ); Tue, 22 Aug 2023 11:50:18 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1B1EE42; Tue, 22 Aug 2023 08:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692719402; x=1724255402; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=FJkJ4AcD733wKA/TC0jO2qVk5wEySRr7m0nT1f3mBfA=; b=POv1vMDI6Dm/70OZus0+Nj5qPYvXB4OoDX22Fkcqc2Nl+okNKzn7UpyD PUOP4FTzAg8y7HobbfwpS6F4/DzWyrTUbMjJIPUnaqwM999l5wjx6Kgdz HknofpTvXa2oXGqx/8VRfskR5r/EQsXG1M9ngcTxvgXVjt4fJsizOu/8Q X8K0gq4w3IziA30kQXkzWuE8QigljfTh74f6toUbzeGEmQQZ2s5iboIHV Zbrp+x6qrzPoQpyNmTmlmY8+BHTpZl90dUcRlLC00e/8j4V+VYR4UIEod 4os7ORrjmwBmgt2G8ZyCooJlW/zS5ocDq8YY9+S/MWm4l7vkFwhYlpuVQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="376658426" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="376658426" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2023 08:49:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="771393764" X-IronPort-AV: E=Sophos;i="6.01,193,1684825200"; d="scan'208";a="771393764" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 22 Aug 2023 08:49:52 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qYTdf-00H1kv-0A; Tue, 22 Aug 2023 18:49:51 +0300 Date: Tue, 22 Aug 2023 18:49:50 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Jiri Kosina , Benjamin Tissoires , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH] HID: cp2112: make the irqchip immutable Message-ID: References: <20230822152244.214394-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Tue, Aug 22, 2023 at 05:38:45PM +0200, Bartosz Golaszewski wrote: > On Tue, Aug 22, 2023 at 5:28 PM Andy Shevchenko > wrote: > > On Tue, Aug 22, 2023 at 05:22:44PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > This make the GPIO irqchip exposed by the CP2112 driver use an immutable > > > irq_chip struct thus addressing the following warning on probe: > > > > > > (cp2112_gpio): not an immutable chip, please consider fixing it! > > > > https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-next&id=3e2977c425ad2789ca18084fff913cceacae75a2 > > > > Can you test HID for-next for this hardware? > > Ah you beat me to it. I didn't see this one. Now looking at it, I don't understand why I added a call to IRQ shutdown callback... (Looks like it slipped from experimental patch.) If you can test this, would be nice. -- With Best Regards, Andy Shevchenko