Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Bagas Sanjaya]

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> Hello,
> After upgrading from 6.5.9 to 6.6.0, my keyboard started acting really weird in its wireless mode, key actions sent are completely wrong, see video attached. 
> 
> Most keys are perceived as either E, 3 or F7, with F8 and <, as well. 
> 
> Modifier keys (CTRL, ALT, ALT GR, Shift and Super) are working normally, as well as media control keys (pause/play, previous, next, mute and sound up/down).
> 
> The keyboard works as expected if it's wired.

Another reporter bisected the regression:

> Bisected to 
> 
> 9d1bd9346241cd6963b58da7ffb7ed303285f684 is the first bad commit
> commit 9d1bd9346241cd6963b58da7ffb7ed303285f684
> Author: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
> Date: Sun Jul 16 18:23:44 2023 +0000
> 
> HID: logitech-dj: Add support for a new lightspeed receiver iteration
> 
> The lightspeed receiver for the Pro X Superlight uses 13 byte mouse reports
> without a report id. The workaround for such cases has been adjusted to
> handle these larger packets.
> 
> The device now reports the status of its battery in wireless mode and
> libratbag now recognizes the device and it can be configured with Piper.
> 
> https://github.com/libratbag/libratbag/pull/1122
> 
> Co-developed-by: Filipe Laíns <lains@riseup.net>
> Signed-off-by: Filipe Laíns <lains@riseup.net>
> Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
> Reviewed-by: Bastien Nocera <hadess@hadess.net>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/hid-logitech-dj.c | 11 ++++++++---
> 2 files changed, 9 insertions(+), 3 deletions(-)

See Bugzilla for the full thread.

Anyway, I'm adding this regression to regzbot:

#regzbot introduced: 9d1bd9346241cd https://bugzilla.kernel.org/show_bug.cgi?id=218094
#regzbot title: Logitech G915 Wireless Keyboard key event only detects few key codes
#regzbot link: https://streamable.com/ac6l8u

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218094

-- 
An old man doll... just what I always wanted! - Clara

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 2610 bytes --]

Hi Thorsten and all,

On Thu, Nov 02, 2023 at 09:11:42PM +0700, Bagas Sanjaya wrote:
> Hi,
> 
> I notice a regression report on Bugzilla [1]. Quoting from it:
> 
> > Hello,
> > After upgrading from 6.5.9 to 6.6.0, my keyboard started acting really weird in its wireless mode, key actions sent are completely wrong, see video attached. 
> > 
> > Most keys are perceived as either E, 3 or F7, with F8 and <, as well. 
> > 
> > Modifier keys (CTRL, ALT, ALT GR, Shift and Super) are working normally, as well as media control keys (pause/play, previous, next, mute and sound up/down).
> > 
> > The keyboard works as expected if it's wired.
> 
> Another reporter bisected the regression:
> 
> > Bisected to 
> > 
> > 9d1bd9346241cd6963b58da7ffb7ed303285f684 is the first bad commit
> > commit 9d1bd9346241cd6963b58da7ffb7ed303285f684
> > Author: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
> > Date: Sun Jul 16 18:23:44 2023 +0000
> > 
> > HID: logitech-dj: Add support for a new lightspeed receiver iteration
> > 
> > The lightspeed receiver for the Pro X Superlight uses 13 byte mouse reports
> > without a report id. The workaround for such cases has been adjusted to
> > handle these larger packets.
> > 
> > The device now reports the status of its battery in wireless mode and
> > libratbag now recognizes the device and it can be configured with Piper.
> > 
> > https://github.com/libratbag/libratbag/pull/1122
> > 
> > Co-developed-by: Filipe Laíns <lains@riseup.net>
> > Signed-off-by: Filipe Laíns <lains@riseup.net>
> > Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
> > Reviewed-by: Bastien Nocera <hadess@hadess.net>
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> > 
> > drivers/hid/hid-ids.h | 1 +
> > drivers/hid/hid-logitech-dj.c | 11 ++++++++---
> > 2 files changed, 9 insertions(+), 3 deletions(-)
> 
> See Bugzilla for the full thread.
> 
> Anyway, I'm adding this regression to regzbot:
> 
> #regzbot introduced: 9d1bd9346241cd https://bugzilla.kernel.org/show_bug.cgi?id=218094
> #regzbot title: Logitech G915 Wireless Keyboard key event only detects few key codes
> #regzbot link: https://streamable.com/ac6l8u
> 

There's no reply from culprit author nor linux-input people (did they miss
this regression?). And on Bugzilla, other reporters replied that reverting
the culprit fixed the regression.

FYI, there's similar Bugzilla report on [1].

Also Cc'ed Linus.

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218172

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Jiri Kosina]

On Tue, 21 Nov 2023, Bagas Sanjaya wrote:

> Hi Thorsten and all,
> 
> On Thu, Nov 02, 2023 at 09:11:42PM +0700, Bagas Sanjaya wrote:
> > Hi,
> > 
> > I notice a regression report on Bugzilla [1]. Quoting from it:
> > 
> > > Hello,
> > > After upgrading from 6.5.9 to 6.6.0, my keyboard started acting really weird in its wireless mode, key actions sent are completely wrong, see video attached. 
> > > 
> > > Most keys are perceived as either E, 3 or F7, with F8 and <, as well. 
> > > 
> > > Modifier keys (CTRL, ALT, ALT GR, Shift and Super) are working normally, as well as media control keys (pause/play, previous, next, mute and sound up/down).
> > > 
> > > The keyboard works as expected if it's wired.
> > 
> > Another reporter bisected the regression:
> > 
> > > Bisected to 
> > > 
> > > 9d1bd9346241cd6963b58da7ffb7ed303285f684 is the first bad commit
> > > commit 9d1bd9346241cd6963b58da7ffb7ed303285f684
> > > Author: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
> > > Date: Sun Jul 16 18:23:44 2023 +0000
> > > 
> > > HID: logitech-dj: Add support for a new lightspeed receiver iteration
> > > 
> > > The lightspeed receiver for the Pro X Superlight uses 13 byte mouse reports
> > > without a report id. The workaround for such cases has been adjusted to
> > > handle these larger packets.
> > > 
> > > The device now reports the status of its battery in wireless mode and
> > > libratbag now recognizes the device and it can be configured with Piper.
> > > 
> > > https://github.com/libratbag/libratbag/pull/1122
> > > 
> > > Co-developed-by: Filipe Laíns <lains@riseup.net>
> > > Signed-off-by: Filipe Laíns <lains@riseup.net>
> > > Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
> > > Reviewed-by: Bastien Nocera <hadess@hadess.net>
> > > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> > > 
> > > drivers/hid/hid-ids.h | 1 +
> > > drivers/hid/hid-logitech-dj.c | 11 ++++++++---
> > > 2 files changed, 9 insertions(+), 3 deletions(-)
> > 
> > See Bugzilla for the full thread.
> > 
> > Anyway, I'm adding this regression to regzbot:
> > 
> > #regzbot introduced: 9d1bd9346241cd https://bugzilla.kernel.org/show_bug.cgi?id=218094
> > #regzbot title: Logitech G915 Wireless Keyboard key event only detects few key codes
> > #regzbot link: https://streamable.com/ac6l8u
> > 
> 
> There's no reply from culprit author nor linux-input people (did they miss
> this regression?). And on Bugzilla, other reporters replied that reverting
> the culprit fixed the regression.
> 
> FYI, there's similar Bugzilla report on [1].

As there was no reaction from Mavroudis in order to figure out why he is 
not observing the issues the other reporters do and what to do to fix 
those, I already do have revert in my queue for -rc3.

My first guess would be that the extra buttons in the extended report are 
not properly reflected in the emulated report descriptor, but that 
wouldn't explain why it worked for the author of the commit.

So revert it is, and once Marvoudis resurfaces, we can try again for some 
of later releases.

-- 
Jiri Kosina
SUSE Labs

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Linux regression tracking (Thorsten Leemhuis)]

On 21.11.23 14:09, Bagas Sanjaya wrote:
> On Thu, Nov 02, 2023 at 09:11:42PM +0700, Bagas Sanjaya wrote:
>> I notice a regression report on Bugzilla [1]. Quoting from it:
>> 
>>> Hello, After upgrading from 6.5.9 to 6.6.0, my keyboard started
>>> acting really weird in its wireless mode, key actions sent are
>>> completely wrong, see video attached.
>>> 
>>> Most keys are perceived as either E, 3 or F7, with F8 and <, as
>>> well.
> [...]
>>> 9d1bd9346241cd6963b58da7ffb7ed303285f684 is the first bad commit 
>>> commit 9d1bd9346241cd6963b58da7ffb7ed303285f684 Author: Mavroudis
>>> Chatzilazaridis <mavchatz@protonmail.com> Date: Sun Jul 16
>>> 18:23:44 2023 +0000
>>> 
>>> HID: logitech-dj: Add support for a new lightspeed receiver
>>> iteration
> [...]
>> 
>> https://bugzilla.kernel.org/show_bug.cgi?id=218094 
> 
> There's no reply from culprit author nor linux-input people (did they
> miss this regression?).

I guess part of the problem is that Bastien got reassigned and might not
care about the kernel anymore.

Another part of it is that Jiri was CCed, but Benjamin was not.

Ideally of course Mavroudis Chatzilazaridis, the culprit's author would
look into this, but from a quick search on lore it looks like Mavroudis
is not a regular kernel contributor and thus might not even know how we
expect situations like this to be handled.

> And on Bugzilla, other reporters replied that
> reverting the culprit fixed the regression.

From Takashi's comments like
https://bugzilla.kernel.org/show_bug.cgi?id=218094#c33 it sounds like
this can be fixed by resolving another regression as discussed earlier
today here:
https://lore.kernel.org/all/87edgjo2kr.wl-tiwai@suse.de/

I think that might be the better solution, but Takashi, Hans, or the
input people will know best.

> FYI, there's similar Bugzilla report on [1].
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=218172

Not sure, that might be a different problem, guess Hans is the best to
judge.

> Also Cc'ed Linus.

Linus can speak for himself, but I guess he gets enough mail already.
I'd say in a situation like this it thus might best to not CC him;
instead poke me when things apparently are not handled well, then we
together can decide if it's worth bringing Linus in.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

On Tue, Nov 21, 2023 at 02:37:52PM +0100, Jiri Kosina wrote:
> On Tue, 21 Nov 2023, Bagas Sanjaya wrote:
> 
> > Hi Thorsten and all,
> > 
> > <snip>...
> > There's no reply from culprit author nor linux-input people (did they miss
> > this regression?). And on Bugzilla, other reporters replied that reverting
> > the culprit fixed the regression.
> > 
> > FYI, there's similar Bugzilla report on [1].
> 
> As there was no reaction from Mavroudis in order to figure out why he is 
> not observing the issues the other reporters do and what to do to fix 
> those, I already do have revert in my queue for -rc3.
> 
> My first guess would be that the extra buttons in the extended report are 
> not properly reflected in the emulated report descriptor, but that 
> wouldn't explain why it worked for the author of the commit.
> 
> So revert it is, and once Marvoudis resurfaces, we can try again for some 
> of later releases.
> 

Thanks for letting us know!

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]

On Tue, Nov 21, 2023 at 02:53:17PM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 21.11.23 14:09, Bagas Sanjaya wrote:
> > On Thu, Nov 02, 2023 at 09:11:42PM +0700, Bagas Sanjaya wrote:
> > <snip>...
> > There's no reply from culprit author nor linux-input people (did they
> > miss this regression?).
> 
> I guess part of the problem is that Bastien got reassigned and might not
> care about the kernel anymore.
> 
> Another part of it is that Jiri was CCed, but Benjamin was not.
> 
> Ideally of course Mavroudis Chatzilazaridis, the culprit's author would
> look into this, but from a quick search on lore it looks like Mavroudis
> is not a regular kernel contributor and thus might not even know how we
> expect situations like this to be handled.
> 
> > And on Bugzilla, other reporters replied that
> > reverting the culprit fixed the regression.
> 
> From Takashi's comments like
> https://bugzilla.kernel.org/show_bug.cgi?id=218094#c33 it sounds like
> this can be fixed by resolving another regression as discussed earlier
> today here:
> https://lore.kernel.org/all/87edgjo2kr.wl-tiwai@suse.de/
> 
> I think that might be the better solution, but Takashi, Hans, or the
> input people will know best.
> 
> > FYI, there's similar Bugzilla report on [1].
> > [1] https://bugzilla.kernel.org/show_bug.cgi?id=218172
> 
> Not sure, that might be a different problem, guess Hans is the best to
> judge.
> 
> > Also Cc'ed Linus.
> 
> Linus can speak for himself, but I guess he gets enough mail already.
> I'd say in a situation like this it thus might best to not CC him;
> instead poke me when things apparently are not handled well, then we
> together can decide if it's worth bringing Linus in.

Thanks for the pro tip!

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Jiri Kosina]

On Tue, 21 Nov 2023, Linux regression tracking (Thorsten Leemhuis) wrote:

> I guess part of the problem is that Bastien got reassigned and might not
> care about the kernel anymore.
> 
> Another part of it is that Jiri was CCed, but Benjamin was not.
> 
> Ideally of course Mavroudis Chatzilazaridis, the culprit's author would
> look into this, but from a quick search on lore it looks like Mavroudis
> is not a regular kernel contributor and thus might not even know how we
> expect situations like this to be handled.

A comment from Mavroudis just appeared in

	https://bugzilla.kernel.org/show_bug.cgi?id=218172

pointing out that indeed the report descriptor of the device he is working 
on is different than the ones from the reporter.

Until this mess gets figured out, I am now pretty sure revert is the way 
to go for 6.7.

-- 
Jiri Kosina
SUSE Labs

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On Tue, Nov 21, 2023 at 03:00:50PM +0100, Jiri Kosina wrote:
> On Tue, 21 Nov 2023, Linux regression tracking (Thorsten Leemhuis) wrote:
> 
> > I guess part of the problem is that Bastien got reassigned and might not
> > care about the kernel anymore.
> > 
> > Another part of it is that Jiri was CCed, but Benjamin was not.
> > 
> > Ideally of course Mavroudis Chatzilazaridis, the culprit's author would
> > look into this, but from a quick search on lore it looks like Mavroudis
> > is not a regular kernel contributor and thus might not even know how we
> > expect situations like this to be handled.
> 
> A comment from Mavroudis just appeared in
> 
> 	https://bugzilla.kernel.org/show_bug.cgi?id=218172
> 
> pointing out that indeed the report descriptor of the device he is working 
> on is different than the ones from the reporter.
> 
> Until this mess gets figured out, I am now pretty sure revert is the way 
> to go for 6.7.
> 

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Mavroudis Chatzilazaridis]

On 2023-11-21 15:37, Jiri Kosina wrote:
> On Tue, 21 Nov 2023, Bagas Sanjaya wrote:
> 
>> Hi Thorsten and all,
>>
>> On Thu, Nov 02, 2023 at 09:11:42PM +0700, Bagas Sanjaya wrote:
>>> Hi,
>>>
>>> I notice a regression report on Bugzilla [1]. Quoting from it:
>>>
>>>> Hello,
>>>> After upgrading from 6.5.9 to 6.6.0, my keyboard started acting really weird in its wireless mode, key actions sent are completely wrong, see video attached.
>>>>
>>>> Most keys are perceived as either E, 3 or F7, with F8 and <, as well.
>>>>
>>>> Modifier keys (CTRL, ALT, ALT GR, Shift and Super) are working normally, as well as media control keys (pause/play, previous, next, mute and sound up/down).
>>>>
>>>> The keyboard works as expected if it's wired.
>>>
>>> Another reporter bisected the regression:
>>>
>>>> Bisected to
>>>>
>>>> 9d1bd9346241cd6963b58da7ffb7ed303285f684 is the first bad commit
>>>> commit 9d1bd9346241cd6963b58da7ffb7ed303285f684
>>>> Author: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
>>>> Date: Sun Jul 16 18:23:44 2023 +0000
>>>>
>>>> HID: logitech-dj: Add support for a new lightspeed receiver iteration
>>>>
>>>> The lightspeed receiver for the Pro X Superlight uses 13 byte mouse reports
>>>> without a report id. The workaround for such cases has been adjusted to
>>>> handle these larger packets.
>>>>
>>>> The device now reports the status of its battery in wireless mode and
>>>> libratbag now recognizes the device and it can be configured with Piper.
>>>>
>>>> https://github.com/libratbag/libratbag/pull/1122
>>>>
>>>> Co-developed-by: Filipe Laíns <lains@riseup.net>
>>>> Signed-off-by: Filipe Laíns <lains@riseup.net>
>>>> Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
>>>> Reviewed-by: Bastien Nocera <hadess@hadess.net>
>>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>>>
>>>> drivers/hid/hid-ids.h | 1 +
>>>> drivers/hid/hid-logitech-dj.c | 11 ++++++++---
>>>> 2 files changed, 9 insertions(+), 3 deletions(-)
>>>
>>> See Bugzilla for the full thread.
>>>
>>> Anyway, I'm adding this regression to regzbot:
>>>
>>> #regzbot introduced: 9d1bd9346241cd https://bugzilla.kernel.org/show_bug.cgi?id=218094
>>> #regzbot title: Logitech G915 Wireless Keyboard key event only detects few key codes
>>> #regzbot link: https://streamable.com/ac6l8u
>>>
>>
>> There's no reply from culprit author nor linux-input people (did they miss
>> this regression?). And on Bugzilla, other reporters replied that reverting
>> the culprit fixed the regression.
>>
>> FYI, there's similar Bugzilla report on [1].
> 
> As there was no reaction from Mavroudis in order to figure out why he is
> not observing the issues the other reporters do and what to do to fix
> those, I already do have revert in my queue for -rc3.
> 
> My first guess would be that the extra buttons in the extended report are
> not properly reflected in the emulated report descriptor, but that
> wouldn't explain why it worked for the author of the commit.
> 
> So revert it is, and once Marvoudis resurfaces, we can try again for some
> of later releases.
> 
> --
> Jiri Kosina
> SUSE Labs
> 

Apologies for not requesting a revert earlier, I was away on vacation 
and didn't realize it would take me this long to get to it.

As I mentioned in this bugzilla report [0], I think the extra buttons 
are handled by vendor defined bytes at the end of the descriptor, so it 
boils down to the emulated descriptor not being updated.
This patch worked for me as the Superlight X that I own only has two 
side buttons. In addition, I was unaware of how many devices this would 
affect.

For now let's make sure this commit is reverted so that people have 
working devices and I will get to fixing the issues that showed up.

Once again, apologies for this.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=218172#c9

Re: Fwd: Logitech G915 Wireless Keyboard acts weird on 6.6.0

[Mavroudis Chatzilazaridis]

On 2023-11-21 16:00, Jiri Kosina wrote:> A comment from Mavroudis just 
appeared in
> 
> 	https://bugzilla.kernel.org/show_bug.cgi?id=218172
> 
> pointing out that indeed the report descriptor of the device he is working
> on is different than the ones from the reporter.
> 
> Until this mess gets figured out, I am now pretty sure revert is the way
> to go for 6.7.
> 
> --
> Jiri Kosina
> SUSE Labs
> 

Greetings everyone,

I have recently made a new patch [0] aimed at addressing the issues that 
have been identified.

I would appreciate it if you could test it and provide any feedback on it.


[0] https://bugzilla.kernel.org/show_bug.cgi?id=218172#c14