From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Even Xu <even.xu@intel.com>
Cc: jikos@kernel.org, srinivas.pandruvada@linux.intel.com,
bleung@chromium.org, groeck@chromium.org,
linux-input@vger.kernel.org, chrome-platform@lists.linux.dev
Subject: Re: [PATCH 4/4] platform: chrome: cros_ec_ishtp: use helper functions for connection
Date: Wed, 6 Dec 2023 11:33:08 +0800 [thread overview]
Message-ID: <ZW_rdCJ7EdtmJYFz@google.com> (raw)
In-Reply-To: <1701741033-26222-5-git-send-email-even.xu@intel.com>
On Tue, Dec 05, 2023 at 09:50:33AM +0800, Even Xu wrote:
> Use helper functions ishtp_cl_establish_connection() and
> ishtp_cl_destroy_connection() to establish and destroy connection
> respectively. These functions are used during initialization, reset and
> deinitialization flows.
>
> No functional changes are expected.
>
> Signed-off-by: Even Xu <even.xu@intel.com>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>
One minor suggestion: we usually use "platform/chrome:" instead of
"platform: chrome:" for the title prefix.
next prev parent reply other threads:[~2023-12-06 3:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 1:50 [PATCH 0/4] Simplify ISHTP client interface Even Xu
2023-12-05 1:50 ` [PATCH 1/4] HID: Intel-ish-hid: Ishtp: Add helper functions for client connection Even Xu
2023-12-05 1:50 ` [PATCH 2/4] HID: intel-ish-hid: ishtp-hid-client: use helper functions for connection Even Xu
2023-12-05 1:50 ` [PATCH 3/4] HID: intel-ish-hid: ishtp-fw-loader: " Even Xu
2023-12-05 1:50 ` [PATCH 4/4] platform: chrome: cros_ec_ishtp: " Even Xu
2023-12-06 3:33 ` Tzung-Bi Shih [this message]
2023-12-06 3:53 ` Xu, Even
2023-12-06 10:34 ` Jiri Kosina
2023-12-08 0:38 ` Xu, Even
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW_rdCJ7EdtmJYFz@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=even.xu@intel.com \
--cc=groeck@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).