* [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example
@ 2023-11-28 21:48 Rob Herring
2023-11-29 8:30 ` Krzysztof Kozlowski
2023-11-29 21:19 ` Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-11-28 21:48 UTC (permalink / raw)
To: Dmitry Torokhov, Krzysztof Kozlowski, Conor Dooley, Orson Zhai,
Baolin Wang, Chunyan Zhang
Cc: linux-input, devicetree, linux-kernel
The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the
binding is the full PMIC, not just the sub-functions. It is preferred
for MFD examples to be complete in the top-level MFD device binding
rather than piecemeal in each sub-function binding.
This also fixes an undocumented (by schema) compatible warning for
"sprd,sc2731".
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/input/sprd,sc27xx-vibrator.yaml | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml b/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
index a401a0bfcbec..4c8d303ff93c 100644
--- a/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
+++ b/Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.yaml
@@ -28,21 +28,4 @@ required:
additionalProperties: false
-examples:
- - |
- #include <dt-bindings/interrupt-controller/arm-gic.h>
- sc2731_pmic: pmic@0 {
- compatible = "sprd,sc2731";
- reg = <0 0>;
- spi-max-frequency = <26000000>;
- interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-controller;
- #interrupt-cells = <2>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- vibrator@eb4 {
- compatible = "sprd,sc2731-vibrator";
- reg = <0xeb4>;
- };
- };
+...
--
2.42.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example
2023-11-28 21:48 [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example Rob Herring
@ 2023-11-29 8:30 ` Krzysztof Kozlowski
2023-11-29 21:19 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-29 8:30 UTC (permalink / raw)
To: Rob Herring, Dmitry Torokhov, Krzysztof Kozlowski, Conor Dooley,
Orson Zhai, Baolin Wang, Chunyan Zhang
Cc: linux-input, devicetree, linux-kernel
On 28/11/2023 22:48, Rob Herring wrote:
> The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the
> binding is the full PMIC, not just the sub-functions. It is preferred
> for MFD examples to be complete in the top-level MFD device binding
> rather than piecemeal in each sub-function binding.
>
> This also fixes an undocumented (by schema) compatible warning for
> "sprd,sc2731".
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example
2023-11-28 21:48 [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example Rob Herring
2023-11-29 8:30 ` Krzysztof Kozlowski
@ 2023-11-29 21:19 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2023-11-29 21:19 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, Orson Zhai, Baolin Wang,
Chunyan Zhang, linux-input, devicetree, linux-kernel
On Tue, Nov 28, 2023 at 03:48:09PM -0600, Rob Herring wrote:
> The example for the Spreadtrum SC27xx PMIC vibrator is incomplete as the
> binding is the full PMIC, not just the sub-functions. It is preferred
> for MFD examples to be complete in the top-level MFD device binding
> rather than piecemeal in each sub-function binding.
>
> This also fixes an undocumented (by schema) compatible warning for
> "sprd,sc2731".
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-29 21:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 21:48 [PATCH] dt-bindings: input: sprd,sc27xx-vibrator: Drop incomplete example Rob Herring
2023-11-29 8:30 ` Krzysztof Kozlowski
2023-11-29 21:19 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).