linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] Input: i8042 - add nomux quirk for Acer P459-G2-M
@ 2023-11-30 19:56 Esther Shimanovich
  2023-11-30 20:04 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Esther Shimanovich @ 2023-11-30 19:56 UTC (permalink / raw)
  To: LKML
  Cc: linux-input, Esther Shimanovich, Dmitry Torokhov, Hans de Goede,
	Jonathan Denose, Mattijs Korpershoek, Werner Sembach

After the laptop lid is opened, and the device resumes from S3 deep
sleep, if the user presses a keyboard key while the screen is still black,
the mouse and keyboard become unusable.

Enabling this quirk prevents this behavior from occurring.

Signed-off-by: Esther Shimanovich <eshimanovich@chromium.org>
---
Hello! Thanks for the prompt response. I had previously tried the
i8042.nomux=1 quirk which didn't seem to work. But I was trying it
together with other quirks, which may have changed the behavior.
When I applied the nomux quirk to the driver, that did fix the bug
on my device. Submitting the new patch!

Changes in v2:
- change noloop to nomux

 drivers/input/serio/i8042-acpipnpio.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/input/serio/i8042-acpipnpio.h b/drivers/input/serio/i8042-acpipnpio.h
index 028e45bd050bf..612c4e3427cef 100644
--- a/drivers/input/serio/i8042-acpipnpio.h
+++ b/drivers/input/serio/i8042-acpipnpio.h
@@ -360,6 +360,14 @@ static const struct dmi_system_id i8042_dmi_quirk_table[] __initconst = {
 		},
 		.driver_data = (void *)(SERIO_QUIRK_DRITEK)
 	},
+	{
+		/* Acer TravelMate P459-G2-M */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate P459-G2-M"),
+		},
+		.driver_data = (void *)(SERIO_QUIRK_NOMUX)
+	},
 	{
 		/* Amoi M636/A737 */
 		.matches = {
-- 
2.43.0.rc2.451.g8631bc7472-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] Input: i8042 - add nomux quirk for Acer P459-G2-M
  2023-11-30 19:56 [PATCH v2] Input: i8042 - add nomux quirk for Acer P459-G2-M Esther Shimanovich
@ 2023-11-30 20:04 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2023-11-30 20:04 UTC (permalink / raw)
  To: Esther Shimanovich
  Cc: LKML, linux-input, Hans de Goede, Jonathan Denose,
	Mattijs Korpershoek, Werner Sembach

On Thu, Nov 30, 2023 at 07:56:19PM +0000, Esther Shimanovich wrote:
> After the laptop lid is opened, and the device resumes from S3 deep
> sleep, if the user presses a keyboard key while the screen is still black,
> the mouse and keyboard become unusable.
> 
> Enabling this quirk prevents this behavior from occurring.
> 
> Signed-off-by: Esther Shimanovich <eshimanovich@chromium.org>

Applied, thank you.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-30 20:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-30 19:56 [PATCH v2] Input: i8042 - add nomux quirk for Acer P459-G2-M Esther Shimanovich
2023-11-30 20:04 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).