From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WRVtDSVd" Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A5141987; Fri, 8 Dec 2023 04:37:19 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9fa45e75ed9so231069766b.1; Fri, 08 Dec 2023 04:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702039038; x=1702643838; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WPQ6igrFJgaAkCCJ/PrY9rvOQPcIfSLQwy5XAAYTFZ4=; b=WRVtDSVdr1jEbYjNP8e/T6GfnH5uuRxJmXv9YwgPsiG+AUR9qqGlrYZQOXX8zS7XNk iRgQlc+fFnMLmU7rFUuscT9vAxWowry4JUg+e45+pLs0IYpLE/EYc6bHGVMUVH1lIfR/ B6GjRVkw9bB6O6RIQdngXqkSJrHDE53LSfZqWgJIeNSWJ+hxSYzKIr8BHBRXyUbhmoZ9 E5/LUQpJOvkrFxB56TWP/Mq2BbvE51na4idJNwSV1dqqBohc6b9kvWiuxFzbpY7hPKsq 9Kqap/OLNDAV7KF/fS9AfP+tQqTU8rxY3C26iYZwgQCaDB4D3Ljc+SKPquPE33qVyN9h /dPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702039038; x=1702643838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WPQ6igrFJgaAkCCJ/PrY9rvOQPcIfSLQwy5XAAYTFZ4=; b=VUhpiLTI6vdkBpB3A2A7qBKu/0hQ+6ptcVcX9ptwvYv3rKh2C3cQY7q6rdMqLCKajP 5UQfpqf8IrQb4ezSziS2wKUoseVFBDoorGHsoehG1zL1loTGOBP36LNdFQZogtaFkx9e aWduvvxW2japOEEa+oFutd2V8NQL1QtLt8FbsiiPz5jJ6g/UvjvuNUgH3Vx8+CJgsyNh 7DfBaSAgOwTKvQ3oiKsmTX2HtCs0bzgOA+x+NlBmUDYQqmfRp2QHxS8lJKDmKvwO2wGh m+kCZUaXcYQa21eV2oKALBWVNkDHxsffNs6kmwZmyTXqk33BeL+ZO4hvk3CSGXO+0CGy nu+g== X-Gm-Message-State: AOJu0Yx2LG+R3BMnnhLdhs28gRjRutUVfyecTj/yWPChFG8+vOdkKVbd 6lF8egy+zLh0O9XK2jTx1D0= X-Google-Smtp-Source: AGHT+IFifdS6Qk1seBmfoJXsGQi4ktaHsgxpPEGE814Znqh9/iODFHgV0KfjFcbZ42XhVpjwJN7Btw== X-Received: by 2002:a17:906:718:b0:a18:35e2:de31 with SMTP id y24-20020a170906071800b00a1835e2de31mr1973793ejb.63.1702039037564; Fri, 08 Dec 2023 04:37:17 -0800 (PST) Received: from eichest-laptop ([2a02:168:af72:0:905b:7c28:f9e2:a6aa]) by smtp.gmail.com with ESMTPSA id jl26-20020a17090775da00b00a1d20467a90sm957286ejc.214.2023.12.08.04.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 04:37:13 -0800 (PST) Date: Fri, 8 Dec 2023 13:37:08 +0100 From: Stefan Eichenberger To: Krzysztof Kozlowski Cc: nick@shmanahar.org, dmitry.torokhov@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, linus.walleij@linaro.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Eichenberger Subject: Re: [PATCH v1 1/2] dt-bindings: input: atmel,maxtouch: add poweroff-in-suspend property Message-ID: References: <20231207111300.80581-1-eichest@gmail.com> <20231207111300.80581-2-eichest@gmail.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Krzysztof, On Thu, Dec 07, 2023 at 05:59:08PM +0100, Krzysztof Kozlowski wrote: > On 07/12/2023 12:12, Stefan Eichenberger wrote: > > diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml > > index c40799355ed7..047a5101341c 100644 > > --- a/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml > > +++ b/Documentation/devicetree/bindings/input/atmel,maxtouch.yaml > > @@ -87,6 +87,12 @@ properties: > > - 2 # ATMEL_MXT_WAKEUP_GPIO > > default: 0 > > > > + atmel,poweroff-in-suspend: > > + description: | > > + When this property is set, all supplies are turned off when the system is > > + going to suspend. > > You described the desired Linux feature or behavior, not the actual > hardware. The bindings are about the latter, so instead you need to > rephrase the property and its description to match actual hardware > capabilities/features/configuration etc. Thanks a lot for the feedback. Would the following be okay as a description? vdda and vdd are switched off in suspend mode. Best regards, Stefan